From: Rusty Russell <rusty@rustcorp.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: laforge@netfilter.org, Jens Axboe <axboe@suse.de>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: Fw: kernel BUG at net/core/skbuff.c:1028!
Date: Thu, 08 May 2003 11:20:27 +1000 [thread overview]
Message-ID: <20030508012101.36E012C01B@lists.samba.org> (raw)
In-Reply-To: Your message of "Wed, 07 May 2003 04:20:03 MST." <20030507.042003.26512841.davem@redhat.com>
In message <20030507.042003.26512841.davem@redhat.com> you write:
> It has to be from some of the skb linearization changes.
> I can't think of any other change we've made that would
> make this start to happen.
Yep, culprit is obvious stupid bug. This indicates a serious lack of
testing on my part 8(
Jens, does this help?
Rusty.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.69-bk2/net/ipv4/netfilter/ip_nat_core.c working-2.5.69-bk2-fix-nat/net/ipv4/netfilter/ip_nat_core.c
--- linux-2.5.69-bk2/net/ipv4/netfilter/ip_nat_core.c 2003-05-08 10:31:08.000000000 +1000
+++ working-2.5.69-bk2-fix-nat/net/ipv4/netfilter/ip_nat_core.c 2003-05-08 11:19:04.000000000 +1000
@@ -870,7 +870,8 @@ icmp_reply_translation(struct sk_buff **
adjustment, so make sure the current checksum is correct. */
if ((*pskb)->ip_summed != CHECKSUM_UNNECESSARY
&& (u16)csum_fold(skb_checksum(*pskb, (*pskb)->nh.iph->ihl*4,
- (*pskb)->len, 0)))
+ (*pskb)->len
+ - (*pskb)->nh.iph->ihl*4, 0)))
return 0;
/* Must be RELATED */
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next parent reply other threads:[~2003-05-08 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030507.042003.26512841.davem@redhat.com>
2003-05-08 1:20 ` Rusty Russell [this message]
2003-05-08 8:34 ` Fw: kernel BUG at net/core/skbuff.c:1028! Jens Axboe
2003-05-08 17:20 ` David S. Miller
2003-05-09 7:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030508012101.36E012C01B@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=axboe@suse.de \
--cc=davem@redhat.com \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).