From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.5.69] Don't use destructor in bridge
Date: Fri, 09 May 2003 21:34:53 -0700 (PDT) [thread overview]
Message-ID: <20030509.213453.23041916.davem@redhat.com> (raw)
In-Reply-To: <20030509131515.6c3d34ca.shemminger@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 9 May 2003 13:15:15 -0700
This patch changes the Ethernet bridge back to the original way
without having a destructor function. This is done so the route
cache side effect code doesn't hold onto a reference to the device.
If destructors are racy and do not work, we don't fix this
by removing destructors from netdevice drivers.
I do not accept this patch. We must fix the core problem.
And your patch even creates a new problem. Remember how Alexey
mentioned that that spinning/sleeping loop in unregister_netdevice()
is deadlock prone and basically illegal itself.
prev parent reply other threads:[~2003-05-10 4:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-09 20:15 [PATCH 2.5.69] Don't use destructor in bridge Stephen Hemminger
2003-05-10 4:34 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030509.213453.23041916.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).