* Re: Where is netif_rx() not safe to use?
[not found] <3ebfa567b38e59.35614148@not right>
@ 2003-05-12 14:59 ` Jeff Garzik
2003-05-12 15:16 ` Jason Lunz
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2003-05-12 14:59 UTC (permalink / raw)
To: Rask Ingemann Lambertsen; +Cc: netdev
On Mon, May 12, 2003 at 03:45:11PM +0200, Rask Ingemann Lambertsen wrote:
>
> Hi.
>
> I'd like to know if there are situations where netif_rx() is not safe to use.
> For example, is it safe to call from a timer or from dev->poll()?
Sure, that's fine.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Where is netif_rx() not safe to use?
2003-05-12 14:59 ` Where is netif_rx() not safe to use? Jeff Garzik
@ 2003-05-12 15:16 ` Jason Lunz
2003-05-12 15:44 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Jason Lunz @ 2003-05-12 15:16 UTC (permalink / raw)
To: netdev
jgarzik@pobox.com said:
>> I'd like to know if there are situations where netif_rx() is not safe to use.
>> For example, is it safe to call from a timer or from dev->poll()?
>
> Sure, that's fine.
from dev->poll()? It could work, but that's abusing the napi design.
netif_rx() is for non-napi drivers. If a dev has a ->poll() method, it
should use netif_receive_skb().
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Where is netif_rx() not safe to use?
2003-05-12 15:16 ` Jason Lunz
@ 2003-05-12 15:44 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2003-05-12 15:44 UTC (permalink / raw)
To: Jason Lunz; +Cc: netdev
On Mon, May 12, 2003 at 03:16:55PM +0000, Jason Lunz wrote:
> jgarzik@pobox.com said:
> >> I'd like to know if there are situations where netif_rx() is not safe to use.
> >> For example, is it safe to call from a timer or from dev->poll()?
> >
> > Sure, that's fine.
>
> from dev->poll()? It could work, but that's abusing the napi design.
> netif_rx() is for non-napi drivers. If a dev has a ->poll() method, it
> should use netif_receive_skb().
agreed.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Where is netif_rx() not safe to use?
@ 2003-05-12 13:45 Rask Ingemann Lambertsen
0 siblings, 0 replies; 4+ messages in thread
From: Rask Ingemann Lambertsen @ 2003-05-12 13:45 UTC (permalink / raw)
To: netdev
Hi.
I'd like to know if there are situations where netif_rx() is not safe to use. For example, is it safe to call from a timer or from dev->poll()?
Regards,
Rask Ingemann Lambertsen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-12 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <3ebfa567b38e59.35614148@not right>
2003-05-12 14:59 ` Where is netif_rx() not safe to use? Jeff Garzik
2003-05-12 15:16 ` Jason Lunz
2003-05-12 15:44 ` Jeff Garzik
2003-05-12 13:45 Rask Ingemann Lambertsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).