* [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit
@ 2003-05-13 22:26 Daniel McNeil
2003-05-13 23:59 ` David S. Miller
2003-05-14 2:46 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 3+ messages in thread
From: Daniel McNeil @ 2003-05-13 22:26 UTC (permalink / raw)
To: netdev@oss.sgi.com; +Cc: davem, kuznet, pekkas, jmorris
[-- Attachment #1: Type: text/plain, Size: 129 bytes --]
ipv6 is missing the calls to kmem_cache_destory() in module_exit
and some cleanup routines.
--
Daniel McNeil <daniel@osdl.org>
[-- Attachment #2: patch.2.5.69-ipv6.kmem --]
[-- Type: text/x-patch, Size: 1328 bytes --]
diff -rupN -X /home/daniel/dontdiff linux-2.5.69/net/ipv6/af_inet6.c linux-2.5.69-ipv6/net/ipv6/af_inet6.c
--- linux-2.5.69/net/ipv6/af_inet6.c Sun May 4 16:53:32 2003
+++ linux-2.5.69-ipv6/net/ipv6/af_inet6.c Tue May 13 11:33:41 2003
@@ -867,6 +867,9 @@ static void inet6_exit(void)
ipv6_sysctl_unregister();
#endif
cleanup_ipv6_mibs();
+ kmem_cache_destroy(tcp6_sk_cachep);
+ kmem_cache_destroy(udp6_sk_cachep);
+ kmem_cache_destroy(raw6_sk_cachep);
}
module_exit(inet6_exit);
#endif /* MODULE */
diff -rupN -X /home/daniel/dontdiff linux-2.5.69/net/ipv6/ip6_fib.c linux-2.5.69-ipv6/net/ipv6/ip6_fib.c
--- linux-2.5.69/net/ipv6/ip6_fib.c Sun May 4 16:53:37 2003
+++ linux-2.5.69-ipv6/net/ipv6/ip6_fib.c Tue May 13 11:33:41 2003
@@ -1241,6 +1241,8 @@ void __init fib6_init(void)
void fib6_gc_cleanup(void)
{
del_timer(&ip6_fib_timer);
+ if (fib6_node_kmem)
+ kmem_cache_destroy(fib6_node_kmem);
}
#endif
diff -rupN -X /home/daniel/dontdiff linux-2.5.69/net/ipv6/route.c linux-2.5.69-ipv6/net/ipv6/route.c
--- linux-2.5.69/net/ipv6/route.c Sun May 4 16:53:36 2003
+++ linux-2.5.69-ipv6/net/ipv6/route.c Tue May 13 11:33:41 2003
@@ -1899,5 +1899,6 @@ void ip6_route_cleanup(void)
xfrm6_fini();
rt6_ifdown(NULL);
fib6_gc_cleanup();
+ kmem_cache_destroy(ip6_dst_ops.kmem_cachep);
}
#endif /* MODULE */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit
2003-05-13 22:26 [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit Daniel McNeil
@ 2003-05-13 23:59 ` David S. Miller
2003-05-14 2:46 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-05-13 23:59 UTC (permalink / raw)
To: daniel; +Cc: netdev, kuznet, pekkas, jmorris
From: Daniel McNeil <daniel@osdl.org>
Date: 13 May 2003 15:26:13 -0700
ipv6 is missing the calls to kmem_cache_destory() in module_exit
and some cleanup routines.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit
2003-05-13 22:26 [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit Daniel McNeil
2003-05-13 23:59 ` David S. Miller
@ 2003-05-14 2:46 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2003-05-14 2:46 UTC (permalink / raw)
To: Daniel McNeil; +Cc: netdev@oss.sgi.com, davem, kuznet, pekkas, jmorris
Em Tue, May 13, 2003 at 03:26:13PM -0700, Daniel McNeil escreveu:
> ipv6 is missing the calls to kmem_cache_destory() in module_exit
> and some cleanup routines.
Thanks, this was overlooked because IPv6 doesn't unloads 8) But this may
well change if we get to some solution to the complex subsystem module handling
that is being discussed recently.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-05-14 2:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-13 22:26 [PATCH 2.5.69] net/ipv6 missing kmem_cache_destroy in module exit Daniel McNeil
2003-05-13 23:59 ` David S. Miller
2003-05-14 2:46 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).