From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@suse.de, olh@suse.de, marcelo@conectiva.com.br, netdev@oss.sgi.com
Subject: Re: comment about struct tcp_tw_bucket in struct sock
Date: Wed, 14 May 2003 21:21:17 +0200 [thread overview]
Message-ID: <20030514192117.GA31303@Wotan.suse.de> (raw)
In-Reply-To: <20030514.121806.41651014.davem@redhat.com>
On Wed, May 14, 2003 at 12:18:06PM -0700, David S. Miller wrote:
> From: Andi Kleen <ak@suse.de>
> Date: Wed, 14 May 2003 10:32:36 +0200
>
> On Tue, May 13, 2003 at 04:31:50PM -0700, David S. Miller wrote:
> > It's documented in tcp.h already.
>
> Just not everybody changing sock.h also reads tcp.h :-(
>
> You assume that protocols in the tree are the only thing
> that might break if you edit struct sock.
I'm not assuming anything and didn't even edit struct sock, just pointing
out that such a fragile hack as the current tw bucket is needs an explicit
comment on both places.
Best would be to bite the bullet and give them a common structure.
-Andi
next prev parent reply other threads:[~2003-05-14 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 21:05 comment about struct tcp_tw_bucket in struct sock Olaf Hering
2003-05-13 23:31 ` David S. Miller
2003-05-14 2:44 ` Arnaldo Carvalho de Melo
2003-05-14 8:00 ` Olaf Hering
2003-05-14 19:17 ` David S. Miller
2003-05-14 19:23 ` Andi Kleen
2003-05-14 19:34 ` David S. Miller
2003-05-14 19:57 ` Andi Kleen
2003-05-14 20:02 ` David S. Miller
2003-05-14 8:32 ` Andi Kleen
2003-05-14 19:18 ` David S. Miller
2003-05-14 19:21 ` Andi Kleen [this message]
2003-05-22 0:52 ` Arnaldo Carvalho de Melo
2003-05-22 8:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030514192117.GA31303@Wotan.suse.de \
--to=ak@suse.de \
--cc=davem@redhat.com \
--cc=marcelo@conectiva.com.br \
--cc=netdev@oss.sgi.com \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).