netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: greg@kroah.com
Cc: shemminger@osdl.org, mochel@osdl.org, netdev@oss.sgi.com,
	jkenisto@us.ibm.com, lkessler@us.ibm.com, dsteklof@us.ibm.com
Subject: Re: [PATCH 1/2] Sysfs net class - infrastructure
Date: Thu, 15 May 2003 17:58:10 -0700 (PDT)	[thread overview]
Message-ID: <20030515.175810.42792746.davem@redhat.com> (raw)
In-Reply-To: <20030516002023.GA11926@kroah.com>

   From: Greg KH <greg@kroah.com>
   Date: Thu, 15 May 2003 17:20:23 -0700

   On Thu, May 15, 2003 at 04:27:17PM -0700, Stephen Hemminger wrote:
   > +#ifdef CONFIG_NET_SYSFS
   
   No, do not make this a config option.

I agree.
   > +	/* statistics object */
   > +	struct kobject		stats_kobj;
   
   What is this needed for?  I don't remember seeing this in your previous
   patches :)

He provides a sub-directory containing statistic value files.
I have no problem with this.

  reply	other threads:[~2003-05-16  0:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-15 23:27 [PATCH 1/2] Sysfs net class - infrastructure Stephen Hemminger
2003-05-16  0:20 ` Greg KH
2003-05-16  0:58   ` David S. Miller [this message]
2003-05-16  1:42     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030515.175810.42792746.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=dsteklof@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=jkenisto@us.ibm.com \
    --cc=lkessler@us.ibm.com \
    --cc=mochel@osdl.org \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).