From: Dave Jones <davej@codemonkey.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [PATCH] iphase fix.
Date: Thu, 15 May 2003 12:32:58 +0100 [thread overview]
Message-ID: <20030515113258.GA31078@suse.de> (raw)
In-Reply-To: <3EC336FE.1030805@pobox.com>
On Thu, May 15, 2003 at 02:43:10AM -0400, Jeff Garzik wrote:
> Jeff Garzik wrote:
> >> dev_kfree_skb(skb);
> >>- else
> >>- netif_wake_queue(dev);
> >>+ netif_wake_queue(dev);
> >> LEAVE("iph5526_send_packet");
> >
> >This appears to revert a fix.
> >You only want to wake the queue if you have room to queue another skb.
>
> Actually, I'm wrong.
>
> But it could still use some looking-at. You don't want to stop_queue at
> the beginning of send_packet and wake_queue at the end. Instead, the
> queue should be awakened in the Tx completion routine, and the
> stop_queue should be moved from the beginning to the end of the function.
Bring it up with whoever merged it into 2.4..
Dave
prev parent reply other threads:[~2003-05-15 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305150417.h4F4HTRA025809@hera.kernel.org>
2003-05-15 6:37 ` [PATCH] iphase fix Jeff Garzik
2003-05-15 6:43 ` Jeff Garzik
2003-05-15 11:32 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030515113258.GA31078@suse.de \
--to=davej@codemonkey.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).