netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: rmk@arm.linux.org.uk
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: Mail delivery failed: returning message to sender
Date: Tue, 20 May 2003 17:55:53 -0700 (PDT)	[thread overview]
Message-ID: <20030520.175553.35669773.davem@redhat.com> (raw)
In-Reply-To: <20030521012148.P10585@flint.arm.linux.org.uk>

   From: Russell King <rmk@arm.linux.org.uk>
   Date: Wed, 21 May 2003 01:21:48 +0100

   fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
   fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
   
   The 1802201956 number is rather interesting.  It's 0x6b6b6b6b, which
   seems to be the slab poison-after.

Russel, thanks for the report.

Alexey, when IP redirect happens during UDP sendfile, all things
go to shit. These messages above were generated by a printk
in ip_append_data() right after maxfraglen is computed.

I STRONGLY suspect the *rt = *rth assignment in
route.c:ip_rt_redirect().  In particular this results in
rt->u.dst.path pointing to the old &rth->u.dst, oops.

Russel, please retest using this patch.  This piece of
code needs to be audited further.

--- net/ipv4/route.c.~1~	Tue May 20 17:53:55 2003
+++ net/ipv4/route.c	Tue May 20 17:54:12 2003
@@ -964,6 +964,7 @@
 				rt->u.dst.neighbour	= NULL;
 				rt->u.dst.hh		= NULL;
 				rt->u.dst.obsolete	= 0;
+				rt->u.dst.path		= &rt->u.dst;
 
 				rt->rt_flags		|= RTCF_REDIRECTED;
 

       reply	other threads:[~2003-05-21  0:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030521012148.P10585@flint.arm.linux.org.uk>
2003-05-21  0:55 ` David S. Miller [this message]
2003-05-21  2:22   ` Mail delivery failed: returning message to sender kuznet
2003-05-21  2:31     ` David S. Miller
2003-05-21  9:07   ` Russell King
     [not found] <20230506214302.B57697534CB0D3D0@vger.kernel.org>
2023-05-06 21:43 ` Mail Delivery System
     [not found] <20230817100924.49044D6518A44C49@vger.kernel.org>
2023-08-17  9:09 ` Mail Delivery System
     [not found] <20230911010529.86EA1B7408F3EC04@vger.kernel.org>
2023-09-11  8:05 ` Mail Delivery System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030520.175553.35669773.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).