* Patch for NETLINK_TCPDIAG
@ 2003-05-20 18:49 Krishna Kumar
2003-05-21 2:26 ` kuznet
2003-05-21 2:33 ` David S. Miller
0 siblings, 2 replies; 4+ messages in thread
From: Krishna Kumar @ 2003-05-20 18:49 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov; +Cc: netdev, linux-net
Hi,
I am not sure if there is a reason why ACK cannot be set for
NETLINK_TCPDIAG.
If it is settable, please apply following patch.
thanks,
- KK
diff -ruN linux-2.5.68.org/net/ipv4/tcp_diag.c linux-2.5.68/net/ipv4/tcp_diag.c
--- linux-2.5.68.org/net/ipv4/tcp_diag.c 2003-05-20 11:38:06.000000000 -0700
+++ linux-2.5.68/net/ipv4/tcp_diag.c 2003-05-20 11:39:48.000000000 -0700
@@ -609,7 +609,7 @@
if (nlh->nlmsg_len < sizeof(*nlh) || skb->len < nlh->nlmsg_len)
return;
err = tcpdiag_rcv_msg(skb, nlh);
- if (err)
+ if (err || nlh->nlmsg_flags & NLM_F_ACK)
netlink_ack(skb, nlh, err);
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch for NETLINK_TCPDIAG
2003-05-20 18:49 Patch for NETLINK_TCPDIAG Krishna Kumar
@ 2003-05-21 2:26 ` kuznet
2003-05-21 2:33 ` David S. Miller
1 sibling, 0 replies; 4+ messages in thread
From: kuznet @ 2003-05-21 2:26 UTC (permalink / raw)
To: Krishna Kumar; +Cc: davem, netdev, linux-net
Hello!
> I am not sure if there is a reason why ACK cannot be set for
> NETLINK_TCPDIAG.
No reasons, indeed.
> If it is settable, please apply following patch.
OK.
> diff -ruN linux-2.5.68.org/net/ipv4/tcp_diag.c linux-2.5.68/net/ipv4/tcp_diag.c
> --- linux-2.5.68.org/net/ipv4/tcp_diag.c 2003-05-20 11:38:06.000000000 -0700
> +++ linux-2.5.68/net/ipv4/tcp_diag.c 2003-05-20 11:39:48.000000000 -0700
> @@ -609,7 +609,7 @@
> if (nlh->nlmsg_len < sizeof(*nlh) || skb->len < nlh->nlmsg_len)
> return;
> err = tcpdiag_rcv_msg(skb, nlh);
> - if (err)
> + if (err || nlh->nlmsg_flags & NLM_F_ACK)
> netlink_ack(skb, nlh, err);
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch for NETLINK_TCPDIAG
2003-05-20 18:49 Patch for NETLINK_TCPDIAG Krishna Kumar
2003-05-21 2:26 ` kuznet
@ 2003-05-21 2:33 ` David S. Miller
1 sibling, 0 replies; 4+ messages in thread
From: David S. Miller @ 2003-05-21 2:33 UTC (permalink / raw)
To: kumarkr; +Cc: kuznet, netdev, linux-net
From: Krishna Kumar <kumarkr@us.ibm.com>
Date: Tue, 20 May 2003 11:49:43 -0700
I am not sure if there is a reason why ACK cannot be set for
NETLINK_TCPDIAG.
If it is settable, please apply following patch.
Your patch does not apply, Lotus NOTES changes tabs into
spaces making the patch unusable.
I've added the fix by hand... but please be mindful of this
in the future.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch for NETLINK_TCPDIAG
@ 2003-05-21 16:25 Krishna Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Krishna Kumar @ 2003-05-21 16:25 UTC (permalink / raw)
To: David S. Miller; +Cc: kuznet, linux-net, netdev
Yes sure, will remember to use a different mailer next time :-)
thanks,
- KK
|---------+---------------------------->
| | "David S. Miller"|
| | <davem@redhat.com|
| | > |
| | |
| | 05/20/2003 07:33 |
| | PM |
| | |
|---------+---------------------------->
>-----------------------------------------------------------------------------------------------------------------|
| |
| To: Krishna Kumar/Beaverton/IBM@IBMUS |
| cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com, linux-net@vger.kernel.org |
| Subject: Re: Patch for NETLINK_TCPDIAG |
| |
>-----------------------------------------------------------------------------------------------------------------|
From: Krishna Kumar <kumarkr@us.ibm.com>
Date: Tue, 20 May 2003 11:49:43 -0700
I am not sure if there is a reason why ACK cannot be set for
NETLINK_TCPDIAG.
If it is settable, please apply following patch.
Your patch does not apply, Lotus NOTES changes tabs into
spaces making the patch unusable.
I've added the fix by hand... but please be mindful of this
in the future.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-21 16:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-20 18:49 Patch for NETLINK_TCPDIAG Krishna Kumar
2003-05-21 2:26 ` kuznet
2003-05-21 2:33 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-05-21 16:25 Krishna Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).