From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: is sk->reuse truly a boolean?
Date: Tue, 20 May 2003 13:58:31 -0300 [thread overview]
Message-ID: <20030520165831.GG801@conectiva.com.br> (raw)
In-Reply-To: <20030521.015317.125867074.yoshfuji@linux-ipv6.org>
Em Wed, May 21, 2003 at 01:53:17AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ escreveu:
> In article <20030520162906.GF801@conectiva.com.br> (at Tue, 20 May 2003 13:29:07 -0300), Arnaldo Carvalho de Melo <acme@conectiva.com.br> says:
>
> > > > In net/core/sock.c, setsockopt it just assigns 1 or 0, i.e. if userspace
> > > > passes > 1 it becomes 1, is this the intended behaviour? I think we have a
> > > > bug in tcp_ipv4 or in core/sock.c 8)
> > >
> > > Good point. However, SO_REUSEADDR works because we have tcp_bind_conflict().
> >
> > mmmkay, so we have to fix it by changing the test to:
> >
> > if (sk->reuse)
> > goto success;
> >
> > Isn't it?
>
> I don't think so. Above modification will break current
> reasonable bind(2) behavior.
>
> Well, it would be dead code, which would be used for (still
> unsupported) SO_REUSEPORT.
So just delete the test?
- Arnaldo
next prev parent reply other threads:[~2003-05-20 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-20 15:57 is sk->reuse truly a boolean? Arnaldo Carvalho de Melo
2003-05-20 16:15 ` YOSHIFUJI Hideaki / 吉藤英明
2003-05-20 16:29 ` Arnaldo Carvalho de Melo
2003-05-20 16:53 ` YOSHIFUJI Hideaki / 吉藤英明
2003-05-20 16:58 ` Arnaldo Carvalho de Melo [this message]
2003-05-20 17:02 ` YOSHIFUJI Hideaki / 吉藤英明
2003-05-20 17:08 ` Arnaldo Carvalho de Melo
2003-05-22 7:01 ` David S. Miller
2003-05-22 7:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030520165831.GG801@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).