Re: Mail delivery failed: returning message to sender

Re: Mail delivery failed: returning message to sender

[David S. Miller]

   From: Russell King <rmk@arm.linux.org.uk>
   Date: Wed, 21 May 2003 01:21:48 +0100

   fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
   fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
   
   The 1802201956 number is rather interesting.  It's 0x6b6b6b6b, which
   seems to be the slab poison-after.

Russel, thanks for the report.

Alexey, when IP redirect happens during UDP sendfile, all things
go to shit. These messages above were generated by a printk
in ip_append_data() right after maxfraglen is computed.

I STRONGLY suspect the *rt = *rth assignment in
route.c:ip_rt_redirect().  In particular this results in
rt->u.dst.path pointing to the old &rth->u.dst, oops.

Russel, please retest using this patch.  This piece of
code needs to be audited further.

--- net/ipv4/route.c.~1~	Tue May 20 17:53:55 2003
+++ net/ipv4/route.c	Tue May 20 17:54:12 2003
@@ -964,6 +964,7 @@
 				rt->u.dst.neighbour	= NULL;
 				rt->u.dst.hh		= NULL;
 				rt->u.dst.obsolete	= 0;
+				rt->u.dst.path		= &rt->u.dst;
 
 				rt->rt_flags		|= RTCF_REDIRECTED;
 

Re: Mail delivery failed: returning message to sender

[kuznet]

Hello!

> I STRONGLY suspect the *rt = *rth assignment in
> route.c:ip_rt_redirect().  In particular this results in
> rt->u.dst.path pointing to the old &rth->u.dst, oops.

Oops, indeed.

> Russel, please retest using this patch.  This piece of
> code needs to be audited further.

Relax, it is right now.

I hope it is the only place where route is copied as whole.

Alexey

Re: Mail delivery failed: returning message to sender

[David S. Miller]

   From: kuznet@ms2.inr.ac.ru
   Date: Wed, 21 May 2003 06:22:10 +0400 (MSD)
   
   > Russel, please retest using this patch.  This piece of
   > code needs to be audited further.
   
   Relax, it is right now.
   
   I hope it is the only place where route is copied as whole.

I explicitly zeroed out child and xfrm in my final version.
These should never be non-NULL, it is pure paranoia on my part :-)

IP6 makes this more intelligently using ip6_route_copy() function.
We should probably make similar beast for ipv4 just for clarity's
sake.

Re: Mail delivery failed: returning message to sender

[Russell King]

On Tue, May 20, 2003 at 05:55:53PM -0700, David S. Miller wrote:
> Russel, please retest using this patch.  This piece of
> code needs to be audited further.

This appears to fix the problem, thanks.

> --- net/ipv4/route.c.~1~	Tue May 20 17:53:55 2003
> +++ net/ipv4/route.c	Tue May 20 17:54:12 2003
> @@ -964,6 +964,7 @@
>  				rt->u.dst.neighbour	= NULL;
>  				rt->u.dst.hh		= NULL;
>  				rt->u.dst.obsolete	= 0;
> +				rt->u.dst.path		= &rt->u.dst;
>  
>  				rt->rt_flags		|= RTCF_REDIRECTED;
>  

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Mail delivery failed: returning message to sender

[Mail Delivery System]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

  netdev@vger.kernel.org
    host vger.kernel.org [23.128.96.18]
    SMTP error from remote mail server after end of data:
    550 5.7.1 Spamassassin considers this message SPAM. In case you disagree, send the ENTIRE message (preferably as a saved attachment) plus this error message to <postmaster@vger.kernel.org>

[-- Attachment #2: Type: message/delivery-status, Size: 363 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 10194 bytes --]

[-- Attachment #3.1: Type: text/html, Size: 9243 bytes --]

From: Noreply vger.kernel.org <netdev@vger.kernel.org>
To: netdev@vger.kernel.org
Subject: Download Incoming Fax Message - OnHold
Date: 6 May 2023 21:43:02 +0000
Message-ID: <20230506214302.B57697534CB0D3D0@vger.kernel.org>

Mail delivery failed: returning message to sender

[Mail Delivery System]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

  netdev@vger.kernel.org
    host vger.kernel.org [23.128.96.18]
    SMTP error from remote mail server after end of data:
    550 5.7.1 Spamassassin considers this message SPAM. In case you disagree, send the ENTIRE message (preferably as a saved attachment) plus this error message to <postmaster@vger.kernel.org>

[-- Attachment #2: Type: message/delivery-status, Size: 363 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 3175 bytes --]

[-- Attachment #3.1: Type: text/html, Size: 2348 bytes --]

From: vger.kernel.orgAdministrator<netdev@vger.kernel.org>
To: netdev@vger.kernel.org
Subject:  ⚠️ WARNING:Some Emails Could not be delivered 
Date: 17 Aug 2023 10:09:25 +0100
Message-ID: <20230817100924.49044D6518A44C49@vger.kernel.org>

Mail delivery failed: returning message to sender

[Mail Delivery System]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

  netdev@vger.kernel.org
    host vger.kernel.org [23.128.96.18]
    SMTP error from remote mail server after end of data:
    550 5.7.1 Spamassassin considers this message SPAM. In case you disagree, send the ENTIRE message (preferably as a saved attachment) plus this error message to <postmaster@vger.kernel.org>

[-- Attachment #2: Type: message/delivery-status, Size: 363 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 21820 bytes --]

[-- Attachment #3.1: Type: text/html, Size: 20465 bytes --]

From: vger.kernel.org admin support <netdev@vger.kernel.org>
To: netdev@vger.kernel.org
Subject: Release Blocked Incoming Messages
Date: 11 Sep 2023 01:05:29 -0700
Message-ID: <20230911010529.86EA1B7408F3EC04@vger.kernel.org>