* Re: Mail delivery failed: returning message to sender
[not found] <20030521012148.P10585@flint.arm.linux.org.uk>
@ 2003-05-21 0:55 ` David S. Miller
2003-05-21 2:22 ` kuznet
2003-05-21 9:07 ` Russell King
0 siblings, 2 replies; 7+ messages in thread
From: David S. Miller @ 2003-05-21 0:55 UTC (permalink / raw)
To: rmk; +Cc: kuznet, netdev
From: Russell King <rmk@arm.linux.org.uk>
Date: Wed, 21 May 2003 01:21:48 +0100
fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
fragheaderlen 20 maxfraglen 1802201956 mtu 1802201963
The 1802201956 number is rather interesting. It's 0x6b6b6b6b, which
seems to be the slab poison-after.
Russel, thanks for the report.
Alexey, when IP redirect happens during UDP sendfile, all things
go to shit. These messages above were generated by a printk
in ip_append_data() right after maxfraglen is computed.
I STRONGLY suspect the *rt = *rth assignment in
route.c:ip_rt_redirect(). In particular this results in
rt->u.dst.path pointing to the old &rth->u.dst, oops.
Russel, please retest using this patch. This piece of
code needs to be audited further.
--- net/ipv4/route.c.~1~ Tue May 20 17:53:55 2003
+++ net/ipv4/route.c Tue May 20 17:54:12 2003
@@ -964,6 +964,7 @@
rt->u.dst.neighbour = NULL;
rt->u.dst.hh = NULL;
rt->u.dst.obsolete = 0;
+ rt->u.dst.path = &rt->u.dst;
rt->rt_flags |= RTCF_REDIRECTED;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Mail delivery failed: returning message to sender
2003-05-21 0:55 ` Mail delivery failed: returning message to sender David S. Miller
@ 2003-05-21 2:22 ` kuznet
2003-05-21 2:31 ` David S. Miller
2003-05-21 9:07 ` Russell King
1 sibling, 1 reply; 7+ messages in thread
From: kuznet @ 2003-05-21 2:22 UTC (permalink / raw)
To: David S. Miller; +Cc: rmk, netdev
Hello!
> I STRONGLY suspect the *rt = *rth assignment in
> route.c:ip_rt_redirect(). In particular this results in
> rt->u.dst.path pointing to the old &rth->u.dst, oops.
Oops, indeed.
> Russel, please retest using this patch. This piece of
> code needs to be audited further.
Relax, it is right now.
I hope it is the only place where route is copied as whole.
Alexey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Mail delivery failed: returning message to sender
2003-05-21 2:22 ` kuznet
@ 2003-05-21 2:31 ` David S. Miller
0 siblings, 0 replies; 7+ messages in thread
From: David S. Miller @ 2003-05-21 2:31 UTC (permalink / raw)
To: kuznet; +Cc: rmk, netdev
From: kuznet@ms2.inr.ac.ru
Date: Wed, 21 May 2003 06:22:10 +0400 (MSD)
> Russel, please retest using this patch. This piece of
> code needs to be audited further.
Relax, it is right now.
I hope it is the only place where route is copied as whole.
I explicitly zeroed out child and xfrm in my final version.
These should never be non-NULL, it is pure paranoia on my part :-)
IP6 makes this more intelligently using ip6_route_copy() function.
We should probably make similar beast for ipv4 just for clarity's
sake.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Mail delivery failed: returning message to sender
2003-05-21 0:55 ` Mail delivery failed: returning message to sender David S. Miller
2003-05-21 2:22 ` kuznet
@ 2003-05-21 9:07 ` Russell King
1 sibling, 0 replies; 7+ messages in thread
From: Russell King @ 2003-05-21 9:07 UTC (permalink / raw)
To: David S. Miller; +Cc: kuznet, netdev
On Tue, May 20, 2003 at 05:55:53PM -0700, David S. Miller wrote:
> Russel, please retest using this patch. This piece of
> code needs to be audited further.
This appears to fix the problem, thanks.
> --- net/ipv4/route.c.~1~ Tue May 20 17:53:55 2003
> +++ net/ipv4/route.c Tue May 20 17:54:12 2003
> @@ -964,6 +964,7 @@
> rt->u.dst.neighbour = NULL;
> rt->u.dst.hh = NULL;
> rt->u.dst.obsolete = 0;
> + rt->u.dst.path = &rt->u.dst;
>
> rt->rt_flags |= RTCF_REDIRECTED;
>
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20230506214302.B57697534CB0D3D0@vger.kernel.org>]
[parent not found: <20230817100924.49044D6518A44C49@vger.kernel.org>]
[parent not found: <20230911010529.86EA1B7408F3EC04@vger.kernel.org>]
end of thread, other threads:[~2023-09-11 8:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20030521012148.P10585@flint.arm.linux.org.uk>
2003-05-21 0:55 ` Mail delivery failed: returning message to sender David S. Miller
2003-05-21 2:22 ` kuznet
2003-05-21 2:31 ` David S. Miller
2003-05-21 9:07 ` Russell King
[not found] <20230506214302.B57697534CB0D3D0@vger.kernel.org>
2023-05-06 21:43 ` Mail Delivery System
[not found] <20230817100924.49044D6518A44C49@vger.kernel.org>
2023-08-17 9:09 ` Mail Delivery System
[not found] <20230911010529.86EA1B7408F3EC04@vger.kernel.org>
2023-09-11 8:05 ` Mail Delivery System
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).