From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: muizelaar@rogers.com, netdev@oss.sgi.com
Subject: Re: [PATCH] post-sysfs netdev cleanup
Date: Tue, 27 May 2003 09:51:29 -0700 [thread overview]
Message-ID: <20030527095129.4bddbc51.shemminger@osdl.org> (raw)
In-Reply-To: <20030525.192417.102551586.davem@redhat.com>
On Sun, 25 May 2003 19:24:17 -0700 (PDT)
"David S. Miller" <davem@redhat.com> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Fri, 23 May 2003 16:47:35 -0700
>
> Seems like a good idea too.
>
> Ok, great.
>
> Stephen, I think we need to find a way to put the device
> registration call outside of the RTNL semaphore. I removed
> in the unregister case, but to be complete we have to push it out in
> the register path too.
>
> The reason for all of these issues is that link_watch grabs the RTNL
> semaphore, and this runs via keventd. Thus, trying to invoke any
> usermode helper (/sbin/hotplug etc.) while holding the RTNL semaphore
> can deadlock.
There needs to be some locking in the registration path doesn't there
to prevent two calls to register the same name and other possible conflicts.
So do you want to use dev_base lock or some other locking?
next prev parent reply other threads:[~2003-05-27 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 0:41 [PATCH] post-sysfs netdev cleanup Jeff Muizelaar
2003-05-23 0:44 ` David S. Miller
[not found] ` <3ECEB317.5020407@osdl.org>
2003-05-26 2:24 ` David S. Miller
2003-05-27 16:51 ` Stephen Hemminger [this message]
2003-05-28 8:33 ` David S. Miller
2003-05-26 2:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030527095129.4bddbc51.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=muizelaar@rogers.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).