netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: aj@dungeon.inka.de
Cc: netdev@oss.sgi.com
Subject: Re: 2.5.70 kernel BUG at net/xfrm/xfrm_policy.c:185!
Date: Thu, 29 May 2003 14:58:21 -0700 (PDT)	[thread overview]
Message-ID: <20030529.145821.38706415.davem@redhat.com> (raw)
In-Reply-To: <1054236655.596.37.camel@simulacron>

   From: Andreas Jellinghaus <aj@dungeon.inka.de>
   Date: 29 May 2003 21:30:55 +0200

   kernel: ------------[ cut here ]------------
   kernel: kernel BUG at net/xfrm/xfrm_policy.c:185!
   kernel: invalid operand: 0000 [#2]

You need to make sure you have Herbert's flow cache refcount
fix applied.

In general, try to run with the current -bk 2.5.x sources
as we fix bugs on almost a daily basis.  I personally consider
2.5.70 as released to be an ancient dinosaur already :-)

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1229.1.176 -> 1.1229.1.177
#	     net/core/flow.c	1.2     -> 1.3    
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/27	herbert@gondor.apana.org.au	1.1229.1.177
# [NET]: Missing refcount bump in flow cache.
# --------------------------------------------
#
diff -Nru a/net/core/flow.c b/net/core/flow.c
--- a/net/core/flow.c	Thu May 29 14:57:31 2003
+++ b/net/core/flow.c	Thu May 29 14:57:31 2003
@@ -199,6 +199,8 @@
 				fle->genid = atomic_read(&flow_cache_genid);
 				fle->object = obj;
 				fle->object_ref = obj_ref;
+				if (obj)
+					atomic_inc(fle->object_ref);
 
 				flow_count(cpu)++;
 			}

      reply	other threads:[~2003-05-29 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-29 19:30 2.5.70 kernel BUG at net/xfrm/xfrm_policy.c:185! Andreas Jellinghaus
2003-05-29 21:58 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030529.145821.38706415.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=aj@dungeon.inka.de \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).