netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: hch@lst.de, netdev@oss.sgi.com
Subject: Re: [PATCH] remove sdla from setup.c
Date: Thu, 29 May 2003 12:36:25 -0300	[thread overview]
Message-ID: <20030529153625.GP24054@conectiva.com.br> (raw)
In-Reply-To: <20030529.025749.59658664.davem@redhat.com>

Em Thu, May 29, 2003 at 02:57:49AM -0700, David S. Miller escreveu:
>    From: Christoph Hellwig <hch@lst.de>
>    Date: Wed, 28 May 2003 13:06:58 +0200
> 
>    sdla had calls from both Space.c and setup.c.  Leave the Space.c one
>    alone as per previous discussion but move over the setup.c one to
>    initcalls.  (and remove the prototype for a third one from setup.c!)
>    
> Looks ok, applied.
> 
> Some of this wan driver stuff is so crappy :(

Crappy? You are being nice...

What about this:

void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags)
{
        spin_lock_irqsave(lock, *smp_flags);
}

Why the hell do we need a bogus wrapper for something so standard?

:-(

- Arnaldo

  reply	other threads:[~2003-05-29 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28 11:06 [PATCH] remove sdla from setup.c Christoph Hellwig
2003-05-29  9:57 ` David S. Miller
2003-05-29 15:36   ` Arnaldo Carvalho de Melo [this message]
2003-05-29 21:03     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030529153625.GP24054@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=hch@lst.de \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).