From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: vnuorval@tcs.hut.fi, netdev@oss.sgi.com
Subject: Re: [PATCH] IPV6: Sereral errors on udpv6_connect()
Date: Tue, 03 Jun 2003 22:46:57 -0700 (PDT) [thread overview]
Message-ID: <20030603.224657.116381839.davem@redhat.com> (raw)
In-Reply-To: <20030604.093944.84705841.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Wed, 04 Jun 2003 09:39:44 +0900 (JST)
This patch fixes multiple errors in udpv6_connect().
- pointer within an automatic storage class variable fl was illegally cached
using ip6_dst_store().
- uninitialized saddr was copied to fl.fl6_src.
- don't cache if ipv6_saddr_get() failed.
Applied.
All these kinds of things need to be done differently once
routing by saddr is supported, more specifically when
route6 lookups make source address selection. Look at
ipv4 side to see the kind of thing I'm talking about.
Yoshfuji-san, remember when Alexey wanted you to change your
source address selection so that it occurred at routing layer?
This is exactly what I'm talking about.
In my view, ipv6 routing is merely a SEVERELY crippled version
of ipv4 routing. Most of ipv6 routing changes needed amount
to merely "porting over" existing ipv4 routing features.
next prev parent reply other threads:[~2003-06-04 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 0:39 [PATCH] IPV6: Sereral errors on udpv6_connect() YOSHIFUJI Hideaki / 吉藤英明
2003-06-04 5:46 ` David S. Miller [this message]
2003-06-13 21:07 ` [patch] IPV6: Refcount leaks in udpv6_connect() Ville Nuorvala
2003-06-14 1:26 ` YOSHIFUJI Hideaki / 吉藤英明
2003-06-15 7:26 ` David S. Miller
2003-06-16 9:22 ` Ville Nuorvala
2003-06-16 12:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030603.224657.116381839.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).