From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.5.70] tulip/xircom initialization bug
Date: Wed, 04 Jun 2003 21:17:50 -0700 (PDT) [thread overview]
Message-ID: <20030604.211750.28820261.davem@redhat.com> (raw)
In-Reply-To: <20030604112136.7b8e2cf4.shemminger@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Wed, 4 Jun 2003 11:21:36 -0700
By inspection of device initialization code, this driver
unregister's the net device in the error path even though the
register_netdevice never succeeded.
This is fully legal, unregister_netdevice() checks for existence of
the netdev in the device list and if not found it returns an error.
This severely simplifies error path handling while we convert all
these drivers away from init_etherdev().
prev parent reply other threads:[~2003-06-05 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 18:21 [PATCH 2.5.70] tulip/xircom initialization bug Stephen Hemminger
2003-06-05 4:17 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604.211750.28820261.davem@redhat.com \
--to=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).