From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: acme@conectiva.com.br, jgarzik@pobox.com, akpm@digeo.com,
jjs@tmsusa.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.5.70] Tun device encapsulation
Date: Wed, 04 Jun 2003 23:50:05 -0700 (PDT) [thread overview]
Message-ID: <20030604.235005.26995218.davem@redhat.com> (raw)
In-Reply-To: <20030604154022.0ef344ff.shemminger@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Wed, 4 Jun 2003 15:40:22 -0700
Tun device was encapsulating the net_device in a private structure
then doing:
unregister_netdev(&tun->dev);
kfree(tun);
rtnl_unlock();
This breaks with the delayed cleanup now in the network core.
Moving the kfree outside of the rtnl_unlock will fix it.
Builds, but not sure how to use TUN to test it.
This seems to indeed fix the problem for people, applied thanks.
prev parent reply other threads:[~2003-06-05 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030604115236.309a173d.akpm@digeo.com>
[not found] ` <20030604212528.GA24515@conectiva.com.br>
2003-06-04 22:40 ` [PATCH 2.5.70] Tun device encapsulation Stephen Hemminger
2003-06-04 22:46 ` jjs
2003-06-05 5:33 ` Joe
2003-06-05 6:50 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604.235005.26995218.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=akpm@digeo.com \
--cc=jgarzik@pobox.com \
--cc=jjs@tmsusa.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).