From: Christoph Hellwig <hch@infradead.org>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, netdev@oss.sgi.com,
Ville Nuorvala <vnuorval@tcs.hut.fi>
Subject: Re: [PATCH] IPV6: typo, unrequired #undef and killing warning
Date: Wed, 4 Jun 2003 07:08:01 +0100 [thread overview]
Message-ID: <20030604070801.A7938@infradead.org> (raw)
In-Reply-To: <20030604.150218.69810413.yoshfuji@linux-ipv6.org>; from yoshfuji@linux-ipv6.org on Wed, Jun 04, 2003 at 03:02:18PM +0900
On Wed, Jun 04, 2003 at 03:02:18PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B wrote:
> st_failure:
> - if (fn && !(fn->fn_flags&RTN_RTINFO|RTN_ROOT))
> - fib_repair_tree(fn);
> + if (fn && !(fn->fn_flags&(RTN_RTINFO|RTN_ROOT)))
This still is not the right codingstyle :) it should be
if (fn && !(fn->fn_flags & (RTN_RTINFO|RTN_ROOT)))
next prev parent reply other threads:[~2003-06-04 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 6:02 [PATCH] IPV6: typo, unrequired #undef and killing warning YOSHIFUJI Hideaki / 吉藤英明
2003-06-04 6:08 ` Christoph Hellwig [this message]
2003-06-04 6:08 ` David S. Miller
2003-06-04 7:47 ` David S. Miller
2003-06-04 9:19 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604070801.A7938@infradead.org \
--to=hch@infradead.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).