From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.5.70] tulip/xircom initialization bug
Date: Wed, 4 Jun 2003 11:21:36 -0700 [thread overview]
Message-ID: <20030604112136.7b8e2cf4.shemminger@osdl.org> (raw)
By inspection of device initialization code, this driver unregister's the net device
in the error path even though the register_netdevice never succeeded.
Compiles, but don't have the hardware.
diff -Nru a/drivers/net/tulip/xircom_tulip_cb.c b/drivers/net/tulip/xircom_tulip_cb.c
--- a/drivers/net/tulip/xircom_tulip_cb.c Wed Jun 4 11:18:44 2003
+++ b/drivers/net/tulip/xircom_tulip_cb.c Wed Jun 4 11:18:44 2003
@@ -648,7 +648,6 @@
pci_set_drvdata(pdev, NULL);
pci_release_regions(pdev);
err_out_free_netdev:
- unregister_netdev(dev);
kfree(dev);
return -ENODEV;
}
next reply other threads:[~2003-06-04 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 18:21 Stephen Hemminger [this message]
2003-06-05 4:17 ` [PATCH 2.5.70] tulip/xircom initialization bug David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604112136.7b8e2cf4.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).