From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: James Morris <jmorris@intercode.com.au>
Cc: Patrick Mansfield <patmans@us.ibm.com>,
Andrew Morton <akpm@digeo.com>,
Stephen Hemminger <shemminger@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
"David S. Miller" <davem@redhat.com>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: 2.5.70-bk+ broken networking
Date: Thu, 5 Jun 2003 00:32:08 -0300 [thread overview]
Message-ID: <20030605033208.GK24515@conectiva.com.br> (raw)
In-Reply-To: <Mutt.LNX.4.44.0306051325110.335-100000@excalibur.intercode.com.au>
For the curious, it was introduced in changeset 1.1259.9.18
- Arnaldo
Em Thu, Jun 05, 2003 at 01:25:58PM +1000, James Morris escreveu:
> On Wed, 4 Jun 2003, Patrick Mansfield wrote:
>
> > [root@elm3b79 root]# ifup eth0
> > sender address length == 0
>
> This is a bug introduced by a coding style cleanup, fix below.
>
>
> - James
> --
> James Morris
> <jmorris@intercode.com.au>
>
> --- bk.pending/net/core/iovec.c 2003-06-05 11:12:59.000000000 +1000
> +++ bk.w1/net/core/iovec.c 2003-06-05 13:30:06.000000000 +1000
> @@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
> address);
> if (err < 0)
> return err;
> - m->msg_name = address;
> - } else
> - m->msg_name = NULL;
> - }
> + }
> + m->msg_name = address;
> + } else
> + m->msg_name = NULL;
>
> size = m->msg_iovlen * sizeof(struct iovec);
> if (copy_from_user(iov, m->msg_iov, size))
>
next prev parent reply other threads:[~2003-06-05 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 23:14 2.5.70-bk+ broken networking Stephen Hemminger
2003-06-04 23:25 ` Stephen Hemminger
2003-06-04 23:25 ` Andrew Morton
2003-06-05 1:43 ` Patrick Mansfield
2003-06-05 3:25 ` James Morris
2003-06-05 3:32 ` Arnaldo Carvalho de Melo [this message]
2003-06-05 5:03 ` David S. Miller
2003-06-05 16:55 ` Stephen Hemminger
2003-06-05 1:56 ` Andrew Morton
2003-06-05 2:33 ` Arnaldo Carvalho de Melo
2003-06-05 2:42 ` Arnaldo Carvalho de Melo
2003-06-05 3:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030605033208.GK24515@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=akpm@digeo.com \
--cc=davem@redhat.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=patmans@us.ibm.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).