From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: davem@redhat.com, ralf@oss.sgi.com, netdev@oss.sgi.com
Subject: Re: [BUG] drivers/net/ioc3_eth.c in 2.5
Date: Mon, 9 Jun 2003 11:08:55 -0700 [thread overview]
Message-ID: <20030609110855.2e264ce1.shemminger@osdl.org> (raw)
In-Reply-To: <20030609171224.GA14623@gtf.org>
On Mon, 9 Jun 2003 13:12:24 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> On Mon, Jun 09, 2003 at 10:10:18AM -0700, Stephen Hemminger wrote:
> > Looks like the right fix is:
> > --- ioc3-eth.c.orig 2003-06-09 10:05:45.000000000 -0700
> > +++ ioc3-eth.c 2003-06-09 10:04:45.000000000 -0700
> > @@ -1614,6 +1614,7 @@ static void __devexit ioc3_remove_one (s
> > struct ioc3 *ioc3 = ip->regs;
> >
> > iounmap(ioc3);
> > + unregister_netdev(dev);
> > pci_release_regions(pdev);
> > kfree(dev);
> > }
>
> You want to unregister before iounmap.
>
> Jeff
>
>
Okay:
--- ioc3-eth.c.orig 2003-06-09 10:05:45.000000000 -0700
+++ ioc3-eth.c 2003-06-09 11:08:01.000000000 -0700
@@ -1613,6 +1613,7 @@ static void __devexit ioc3_remove_one (s
struct ioc3_private *ip = dev->priv;
struct ioc3 *ioc3 = ip->regs;
+ unregister_netdev(dev);
iounmap(ioc3);
pci_release_regions(pdev);
kfree(dev);
next prev parent reply other threads:[~2003-06-09 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030606161658.1f01b8f9.shemminger@osdl.org>
[not found] ` <20030607.013010.116359540.davem@redhat.com>
2003-06-09 17:10 ` [BUG] drivers/net/ioc3_eth.c in 2.5 Stephen Hemminger
2003-06-09 17:09 ` David S. Miller
2003-06-09 17:12 ` Jeff Garzik
2003-06-09 18:08 ` Stephen Hemminger [this message]
2003-06-11 11:50 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609110855.2e264ce1.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).