From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: netdev@oss.sgi.com
Subject: Re: [RFT] remove skb_linearize from igmp.c
Date: Mon, 23 Jun 2003 12:02:29 -0700 (PDT) [thread overview]
Message-ID: <20030623.120229.59679308.davem@redhat.com> (raw)
In-Reply-To: <20030623120342.470cf504.shemminger@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Mon, 23 Jun 2003 12:03:42 -0700
Could someone who actually receives IGMP packets test this?
Don't bother, your patch is buggy.
int len = skb->len;
...
+ if (!pskb_may_pull(skb, sizeof(struct igmphdr)))
+ goto drop;
+
+ ih = skb->h.igmph;
+ if (ip_compute_csum((void *)ih, len))
+ goto drop;
You're only verifying that "sizeof(struct igmphdr)" is available at
skb->data, then you dereference "len" bytes via the call to
ip_compute_csum().
next prev parent reply other threads:[~2003-06-23 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 19:03 [RFT] remove skb_linearize from igmp.c Stephen Hemminger
2003-06-23 19:02 ` David S. Miller [this message]
2003-06-23 19:41 ` Stephen Hemminger
2003-06-23 20:17 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623.120229.59679308.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).