From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] PPP handling fragmented skbuff's
Date: Sat, 28 Jun 2003 00:21:29 -0700 (PDT) [thread overview]
Message-ID: <20030628.002129.35022526.davem@redhat.com> (raw)
In-Reply-To: <20030627163524.347b2c8e.shemminger@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 27 Jun 2003 16:35:24 -0700
Don't think this ever happens today, but if PPP ever gets a
fragmented a skbuff and decides to copy it then bad things will
happen. The following replaces the places that memcpy() with
skb_copy_bits().
Please review carefully before applying, it builds and runs but
can't really force these code path to occur under normal systems
and devices.
It looks ok. But I'll let this one sit over the weekend
before applying so others can test it out.
next prev parent reply other threads:[~2003-06-28 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-27 23:35 [PATCH] PPP handling fragmented skbuff's Stephen Hemminger
2003-06-28 7:21 ` David S. Miller [this message]
2003-07-10 2:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030628.002129.35022526.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).