From: Matthew Wilcox <willy@debian.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Matthew Wilcox <willy@debian.org>, netdev@oss.sgi.com
Subject: Re: [PATCH] netdev_ops
Date: Tue, 8 Jul 2003 22:25:51 +0100 [thread overview]
Message-ID: <20030708212551.GL1939@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3F0B2D30.4020102@candelatech.com>
On Tue, Jul 08, 2003 at 01:44:32PM -0700, Ben Greear wrote:
> Some of these are missing their netdevice arg?
> >+ int (*get_regs_len)(struct ethtool_regs *);
> >+ int (*self_test_len)(struct ethtool_test *);
> >+ int (*get_strings_len)(struct ethtool_gstrings *);
> >+ int (*get_stats_len)(struct ethtool_stats *);
Well, they don't actually need it -- these are more attributes of
the underlying driver than they are of any individual network device.
I suspect at least one of them isn't needed, and I'm sure the e1000 guys
are about to tell me which one ;-)
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-07-08 21:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 16:30 [PATCH] netdev_ops Matthew Wilcox
2003-07-08 20:44 ` Ben Greear
2003-07-08 21:25 ` Matthew Wilcox [this message]
2003-07-08 22:08 ` David S. Miller
2003-07-09 16:15 ` Matthew Wilcox
2003-07-09 17:11 ` Ben Greear
2003-07-09 17:25 ` Matthew Wilcox
2003-07-09 18:14 ` Jeff Garzik
2003-07-09 18:24 ` Ben Greear
2003-07-11 19:32 ` Jeff Garzik
2003-07-11 19:51 ` Ben Greear
2003-07-11 19:58 ` Jeff Garzik
2003-07-11 20:07 ` Ben Greear
2003-07-11 20:04 ` Matthew Wilcox
2003-07-14 5:53 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2003-07-10 7:47 Feldman, Scott
2003-07-10 7:42 ` David S. Miller
2003-07-10 11:21 ` Matthew Wilcox
2003-07-10 13:06 ` Jeff Garzik
2003-07-10 8:18 Feldman, Scott
2003-07-10 20:37 ` David S. Miller
2003-07-11 0:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030708212551.GL1939@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).