From: Thomas Graf <tgraf@suug.ch>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, jmorris@intercode.com.au, netdev@oss.sgi.com
Subject: Re: [PATCH] IPV6: fix data offset calculation when pushing frag options {dst1opts|auth}
Date: Fri, 11 Jul 2003 02:27:13 +0200 [thread overview]
Message-ID: <20030711002713.GC30577@rei.rakuen> (raw)
In-Reply-To: <20030711.091814.128467921.yoshfuji@linux-ipv6.org>
* yoshfuji@linux-ipv6.org wrote:
> + exthdrlen += rt->u.dst.header_len + (opt ? opt->opt_flen : 0);
exthdrlen is uninitialized.
New patch:
Index: net/ipv6/ip6_output.c
===================================================================
RCS file: /cvs/tgr/linux-25/net/ipv6/ip6_output.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 ip6_output.c
--- net/ipv6/ip6_output.c 10 Jul 2003 22:58:50 -0000 1.1.1.2
+++ net/ipv6/ip6_output.c 10 Jul 2003 23:36:48 -0000
@@ -1247,11 +1247,9 @@
inet->cork.length = 0;
inet->sndmsg_page = NULL;
inet->sndmsg_off = 0;
- if ((exthdrlen = rt->u.dst.header_len) != 0) {
- length += exthdrlen;
- transhdrlen += exthdrlen;
- }
- exthdrlen += opt ? opt->opt_flen : 0;
+ exthdrlen = rt->u.dst.header_len + (opt ? opt->opt_flen : 0);
+ length += exthdrlen;
+ transhdrlen += exthdrlen;
} else {
rt = np->cork.rt;
if (inet->cork.flags & IPCORK_OPT)
next prev parent reply other threads:[~2003-07-11 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-10 23:44 [PATCH] IPV6: fix data offset calculation when pushing frag options {dst1opts|auth} Thomas Graf
2003-07-11 0:18 ` YOSHIFUJI Hideaki / 吉藤英明
2003-07-11 0:24 ` YOSHIFUJI Hideaki / 吉藤英明
2003-07-11 0:18 ` David S. Miller
2003-07-11 0:27 ` Thomas Graf [this message]
2003-07-11 0:22 ` David S. Miller
2003-07-11 0:32 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030711002713.GC30577@rei.rakuen \
--to=tgraf@suug.ch \
--cc=davem@redhat.com \
--cc=jmorris@intercode.com.au \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).