* e1000 typo?
@ 2003-07-30 17:21 Jason Lunz
0 siblings, 0 replies; 3+ messages in thread
From: Jason Lunz @ 2003-07-30 17:21 UTC (permalink / raw)
To: scott.feldman; +Cc: netdev
The diff between the 5.1.11 and the newest e1000 drivers has this hunk:
@@ -1999,7 +1996,7 @@
}
#else
for(i = 0; i < E1000_MAX_INTR; i++)
- if(!e1000_clean_rx_irq(adapter) &&
+ if(!e1000_clean_rx_irq(adapter) &
!e1000_clean_tx_irq(adapter))
break;
#endif
is that intentional? I don't think it changes the code behavior, but it
doesn't look right.
--
Jason Lunz Reflex Security
lunz@reflexsecurity.com http://www.reflexsecurity.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: e1000 typo?
@ 2003-07-30 18:24 Feldman, Scott
2003-07-30 18:29 ` Jason Lunz
0 siblings, 1 reply; 3+ messages in thread
From: Feldman, Scott @ 2003-07-30 18:24 UTC (permalink / raw)
To: Jason Lunz; +Cc: netdev
> is that intentional? I don't think it changes the code
> behavior, but it doesn't look right.
It's intentional because && stops evaluating if left op is false which
means we would leave Tx cleanup work when there was no Rx work.
-scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: e1000 typo?
2003-07-30 18:24 Feldman, Scott
@ 2003-07-30 18:29 ` Jason Lunz
0 siblings, 0 replies; 3+ messages in thread
From: Jason Lunz @ 2003-07-30 18:29 UTC (permalink / raw)
To: Feldman, Scott; +Cc: netdev
On Wed, Jul 30, 2003 at 11:24AM -0700, Feldman, Scott wrote:
> It's intentional because && stops evaluating if left op is false which
> means we would leave Tx cleanup work when there was no Rx work.
ah. subtle yet obvious. :P
--
Jason Lunz Reflex Security
lunz@reflexsecurity.com http://www.reflexsecurity.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-07-30 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-30 17:21 e1000 typo? Jason Lunz
-- strict thread matches above, loose matches on Subject: below --
2003-07-30 18:24 Feldman, Scott
2003-07-30 18:29 ` Jason Lunz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).