From: Jan Oravec <jan.oravec@6com.sk>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: [PATCH] IPV6: strategy hander for net.ipv6.conf.*.forwarding (is Re: problem setting net.ipvX.conf.all.forwarding via sysctl() system call)
Date: Fri, 8 Aug 2003 11:37:04 +0200 [thread overview]
Message-ID: <20030808093704.GA18131@wsx.ksp.sk> (raw)
In-Reply-To: <20030808.175030.19527061.yoshfuji@linux-ipv6.org>
On Fri, Aug 08, 2003 at 05:50:30PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> + *valp = new;
> + if (valp != &ipv6_devconf.forwarding &&
> + valp != &ipv6_devconf_dflt.forwarding) {
> + struct inet6_dev *idev = (struct inet6_dev *)table->extra1;
> + if (!idev)
> + return -ENODEV;
> + addrconf_forward_change(idev);
> + }
> + return 0;
> +}
Shouldn't we set ipv6_devconf_dflt.forwarding and call
addr_forward_change(NULL) in case that valp==&ipv6_devconf.forwarding?
--
Jan Oravec XS26 coordinator
6COM s.r.o. 'Access to IPv6'
http://www.6com.sk http://www.xs26.net
next prev parent reply other threads:[~2003-08-08 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 15:44 problem setting net.ipvX.conf.all.forwarding via sysctl() system call Jan Oravec
2003-08-08 8:45 ` YOSHIFUJI Hideaki / 吉藤英明
2003-08-08 9:11 ` Jan Oravec
2003-08-09 8:06 ` David S. Miller
2003-08-08 8:50 ` [PATCH] IPV6: strategy hander for net.ipv6.conf.*.forwarding (is Re: problem setting net.ipvX.conf.all.forwarding via sysctl() system call) YOSHIFUJI Hideaki / 吉藤英明
2003-08-08 9:37 ` Jan Oravec [this message]
2003-08-08 9:51 ` YOSHIFUJI Hideaki / 吉藤英明
2003-08-08 11:39 ` Jan Oravec
2003-08-09 8:08 ` David S. Miller
2003-08-09 10:21 ` YOSHIFUJI Hideaki / 吉藤英明
2003-08-09 21:44 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030808093704.GA18131@wsx.ksp.sk \
--to=jan.oravec@6com.sk \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).