From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: Re: RFR: new SiS gige driver
Date: Fri, 8 Aug 2003 23:39:40 -0700 [thread overview]
Message-ID: <20030808233940.6ad767f5.davem@redhat.com> (raw)
In-Reply-To: <20030808173932.GA4077@gtf.org>
On Fri, 8 Aug 2003 13:39:33 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> This driver is actually a lot more clean than many that crop up. So far
> most of my nits are minor:
egrep virt_to_bus sis190.c
:-(
I think this is more important to fix than any of the other things
which have been listed. I really believe we're at the point where
putting PCI device drivers into the tree still using virt_to_bus() and
friends should simply not be allowed...
next prev parent reply other threads:[~2003-08-09 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-08 17:39 RFR: new SiS gige driver Jeff Garzik
2003-08-08 19:01 ` Stephen Hemminger
2003-08-09 6:39 ` David S. Miller [this message]
2003-08-09 14:15 ` Andi Kleen
2003-08-09 15:01 ` Jeff Garzik
2003-08-09 15:27 ` Andi Kleen
2003-08-11 1:07 ` Jeff Garzik
2003-08-09 18:10 ` Ben Greear
2003-08-13 18:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030808233940.6ad767f5.davem@redhat.com \
--to=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).