netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: chas williams <chas@cmf.nrl.navy.mil>, netdev@oss.sgi.com
Subject: Re: [RFT][PATCH] cleanup net/atm/br2684.c
Date: Mon, 11 Aug 2003 14:58:57 -0700	[thread overview]
Message-ID: <20030811215857.GA96728@gaz.sfgoth.com> (raw)
In-Reply-To: <20030811114823.5b81474c.shemminger@osdl.org>

You might also want to send this patch to the linux-atm mailing list:
  linux-atm-general@lists.sourceforge.net
Unfortunately you need to subscribe to post.
  http://lists.sourceforge.net/lists/listinfo/linux-atm-general

Not sure how many ATM users are following 2.6 yet though.  I might be
able to give it a spin soon.

> -			unregister_netdev(&brdev->net_dev);
> -			kfree(brdev);
> +			unregister_netdev(brdev->net_dev);
> +			kfree(brdev->net_dev);

Mmmm.. I see this snippet in your diff in multiplce places and it looks
wrong.  Where does the "brdev" structure get freed now?

-Mitch

  reply	other threads:[~2003-08-11 21:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-11 18:48 [RFT][PATCH] cleanup net/atm/br2684.c Stephen Hemminger
2003-08-11 21:58 ` Mitchell Blank Jr [this message]
2003-08-11 22:30   ` Stephen Hemminger
2003-08-13  1:09     ` Mitchell Blank Jr
2003-08-12  5:49 ` David S. Miller
2003-08-12 16:44 ` chas williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030811215857.GA96728@gaz.sfgoth.com \
    --to=mitch@sfgoth.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).