* [PATCH] Missing break in switch statement.
@ 2003-08-11 16:48 davej
2003-08-11 17:14 ` YOSHIFUJI Hideaki
0 siblings, 1 reply; 3+ messages in thread
From: davej @ 2003-08-11 16:48 UTC (permalink / raw)
To: netdev
Is this intentional? It should at least have a
/* FALLTHROUGH */ or similar if so.
Dave
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/net/ipv6/raw.c linux-2.5/net/ipv6/raw.c
--- bk-linus/net/ipv6/raw.c 2003-07-11 13:57:41.000000000 +0100
+++ linux-2.5/net/ipv6/raw.c 2003-07-11 14:08:05.000000000 +0100
@@ -833,6 +833,7 @@ static int rawv6_getsockopt(struct sock
val = -1;
else
val = opt->offset;
+ break;
default:
return -ENOPROTOOPT;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Missing break in switch statement.
2003-08-11 16:48 [PATCH] Missing break in switch statement davej
@ 2003-08-11 17:14 ` YOSHIFUJI Hideaki
2003-08-12 5:26 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2003-08-11 17:14 UTC (permalink / raw)
To: davem, davej; +Cc: netdev, yoshfuji
In article <E19mFqr-00068T-00@tetrachloride> (at Mon, 11 Aug 2003 17:48:57 +0100), davej@redhat.com says:
> Is this intentional? It should at least have a
> /* FALLTHROUGH */ or similar if so.
Of course not.
> else
> val = opt->offset;
> + break;
>
> default:
> return -ENOPROTOOPT;
agreed.
--yoshfuji
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Missing break in switch statement.
2003-08-11 17:14 ` YOSHIFUJI Hideaki
@ 2003-08-12 5:26 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-08-12 5:26 UTC (permalink / raw)
To: YOSHIFUJI Hideaki; +Cc: davej, netdev, yoshfuji
On Tue, 12 Aug 2003 02:14:14 +0900 (JST)
YOSHIFUJI Hideaki <yoshfuji@hongo.wide.ad.jp> wrote:
> In article <E19mFqr-00068T-00@tetrachloride> (at Mon, 11 Aug 2003 17:48:57 +0100), davej@redhat.com says:
>
> > Is this intentional? It should at least have a
> > /* FALLTHROUGH */ or similar if so.
>
> Of course not.
Patch applied, thanks David.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-12 5:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-11 16:48 [PATCH] Missing break in switch statement davej
2003-08-11 17:14 ` YOSHIFUJI Hideaki
2003-08-12 5:26 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).