From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: chas williams <chas@cmf.nrl.navy.mil>, netdev@oss.sgi.com
Subject: Re: [RFT][PATCH] cleanup net/atm/br2684.c
Date: Tue, 12 Aug 2003 18:09:17 -0700 [thread overview]
Message-ID: <20030813010917.GC36444@gaz.sfgoth.com> (raw)
In-Reply-To: <20030811153039.6df304fb.shemminger@osdl.org>
Stephen Hemminger wrote:
> > Mmmm.. I see this snippet in your diff in multiplce places and it looks
> > wrong. Where does the "brdev" structure get freed now?
> >
> The brdev structure is contained inside the allocation of net_device,
> this is how all the ether and other devices do it.
OK, sorry... that should have been obvious. The reason I was confused is
that almost always the net_dev is referenced as brdev->net_dev which makes
look like brdev merely has a reference to net_dev. I think it would be
cleaner to change the code to pass around "net_dev" instead of "brdev"
references (and just get the brdev via net_dev->priv as needed) and just
get rid of the brdev->net_dev pointer entirely.
Are you interested in doing that? Otherwise I could take a crack at it
when I get the chance (I've done some surgery on this file before)
-Mitch
next prev parent reply other threads:[~2003-08-13 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 18:48 [RFT][PATCH] cleanup net/atm/br2684.c Stephen Hemminger
2003-08-11 21:58 ` Mitchell Blank Jr
2003-08-11 22:30 ` Stephen Hemminger
2003-08-13 1:09 ` Mitchell Blank Jr [this message]
2003-08-12 5:49 ` David S. Miller
2003-08-12 16:44 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030813010917.GC36444@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).