From: "David S. Miller" <davem@redhat.com>
To: Jeroen Vreeken <pe1rxq@amsat.org>
Cc: shemminger@osdl.org, pe1rxq@amsat.org,
linux-hams@vger.kernel.org, ralf@linux-mips.org,
netdev@oss.sgi.com
Subject: Re: [PATCH] ax25 & netrom fixes for 2.6
Date: Wed, 13 Aug 2003 03:10:38 -0700 [thread overview]
Message-ID: <20030813031038.2c2afc6d.davem@redhat.com> (raw)
In-Reply-To: <20030812230951.E28977@jeroen.pe1rxq.ampr.org>
On Tue, 12 Aug 2003 23:09:51 +0200
Jeroen Vreeken <pe1rxq@amsat.org> wrote:
> Since at the moment the only zero-copy path I can imagine is from packets
> over a bpq ethernet device wouldn't it be the easiest to just check at
> ax25_rcv() for non-linear packets and call skb_linearize() for them?
skb_linearize() is a deprecated interface, no new pieces of
code should use it. If you want to mark the protocol as a new
one you must do the non-linear handling properly just like every
other protocol.
Please, if you're going to be working in this area, fix this up properly
and don't paper around the problems Stephen is showing to you.
prev parent reply other threads:[~2003-08-13 10:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 17:46 [PATCH] ax25 & netrom fixes for 2.6 Jeroen Vreeken
2003-08-12 19:48 ` Stephen Hemminger
2003-08-12 20:59 ` Jeroen Vreeken
2003-08-12 20:56 ` Stephen Hemminger
2003-08-12 21:09 ` Jeroen Vreeken
2003-08-12 22:39 ` [PATCH] ax25 fix for premature free Stephen Hemminger
2003-08-12 23:03 ` Jeroen Vreeken
2003-08-12 23:49 ` [PATCH] ax25 use dev_hold/dev_put as required for net_devices Stephen Hemminger
2003-08-13 0:19 ` [PATCH] ax25 setsockopt(SO_BINDTODEVICE) bug fix Stephen Hemminger
2003-08-13 0:21 ` [PATCH] Convert ax25 to seq_file Stephen Hemminger
2003-08-13 10:11 ` David S. Miller
2003-08-13 15:34 ` Jeroen Vreeken
2003-08-13 15:42 ` David S. Miller
2003-08-13 22:35 ` [PATCH] (0/11) Netrom patches Stephen Hemminger
2003-08-15 4:13 ` David S. Miller
2003-08-20 18:45 ` [PATCH] ax25 changes Jeroen Vreeken
2003-08-21 19:18 ` David S. Miller
2003-08-22 20:13 ` [PATCH] ax25 - make sure and hold ref to dev Stephen Hemminger
2003-08-24 11:28 ` David S. Miller
2003-08-22 20:15 ` [RFT][PATCH] ax25 using seq_file Stephen Hemminger
2003-08-24 11:29 ` David S. Miller
2003-08-24 22:35 ` Jeroen Vreeken
2003-08-13 10:10 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030813031038.2c2afc6d.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=pe1rxq@amsat.org \
--cc=ralf@linux-mips.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).