From: Stephen Hemminger <shemminger@osdl.org>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: "David S. Miller" <davem@redhat.com>,
Jeroen Vreeken <pe1rxq@amsat.org>,
linux-hams@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file
Date: Thu, 14 Aug 2003 11:30:25 -0700 [thread overview]
Message-ID: <20030814113025.2b40be14.shemminger@osdl.org> (raw)
In-Reply-To: <20030814172539.GD1785@conectiva.com.br>
On Thu, 14 Aug 2003 14:25:39 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
> Em Wed, Aug 13, 2003 at 03:46:35PM -0700, Stephen Hemminger escreveu:
> > Convert netrom /proc interface to seq_file.
> >
> > diff -Nru a/include/net/netrom.h b/include/net/netrom.h
> > --- a/include/net/netrom.h Wed Aug 13 13:54:19 2003
> > +++ b/include/net/netrom.h Wed Aug 13 13:54:19 2003
> > + seq_printf(seq, "%-9s ", ax2asc(&nr->user_addr));
> > + seq_printf(seq, "%-9s ", ax2asc(&nr->dest_addr));
> > + seq_printf(seq,
> > +"%-9s %-3s %02X/%02X %02X/%02X %2d %3d %3d %3d %3lu/%03lu %2lu/%02lu %3lu/%03lu %3lu/%03lu %2d/%02d %3d %5d %5d %ld\n",
>
> <nitpick> why not just one seq_printf call? </nitpick>
ax2asc() returns a pointer to static buffer.
next prev parent reply other threads:[~2003-08-14 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 22:46 [PATCH] (10/11) netrom - convert /proc interface to seq_file Stephen Hemminger
2003-08-14 17:25 ` Arnaldo Carvalho de Melo
2003-08-14 18:30 ` Stephen Hemminger [this message]
2003-08-15 21:12 ` Arnaldo Carvalho de Melo
2003-08-15 21:47 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030814113025.2b40be14.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=pe1rxq@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).