From: Dan Aloni <da-x@gmx.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>,
Linux Net-Dev <netdev@oss.sgi.com>, Mark Huth <mhuth@mvista.com>
Subject: Re: [PATCH] network device renaming sysfs fix
Date: Fri, 15 Aug 2003 19:50:48 +0300 [thread overview]
Message-ID: <20030815165048.GA11014@callisto.yi.org> (raw)
In-Reply-To: <20030815093724.519779e6.shemminger@osdl.org>
On Fri, Aug 15, 2003 at 09:37:24AM -0700, Stephen Hemminger wrote:
> Yes, this is a better fix because it won't break when unregister and free are split
> into seperate steps (coming soon).
>
> But, do we really need the debug message?
> Why return an error if you already committed the change? If you get an error,
> then don't rename the network device.
>
> The class_dev kobject name is 20 chars and IFNAMSIZ is 16, so the solution
> needs to truncate if new_name is not null terminated (all 16 chars long).
>
> This seems like the best approach:
Agreed.
> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c Fri Aug 15 09:34:11 2003
> +++ b/net/core/dev.c Fri Aug 15 09:34:11 2003
[patch]
--
Dan Aloni
da-x@gmx.net
next prev parent reply other threads:[~2003-08-15 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-15 11:15 [PATCH] network device renaming sysfs fix Dan Aloni
2003-08-15 16:37 ` Stephen Hemminger
2003-08-15 16:50 ` Dan Aloni [this message]
2003-08-16 14:40 ` David S. Miller
2003-08-17 7:13 ` Dan Aloni
2003-08-15 18:09 ` Mark Huth
-- strict thread matches above, loose matches on Subject: below --
2003-08-15 11:36 Hen, Shmulik
2003-08-15 11:45 ` Dan Aloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030815165048.GA11014@callisto.yi.org \
--to=da-x@gmx.net \
--cc=davem@redhat.com \
--cc=mhuth@mvista.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).