netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
	"David S. Miller" <davem@redhat.com>,
	netdev@oss.sgi.com
Subject: Re: [PATCH] fix build problem with IPV6
Date: Fri, 15 Aug 2003 18:19:38 -0300	[thread overview]
Message-ID: <20030815211938.GM1564@conectiva.com.br> (raw)
In-Reply-To: <20030815140740.388a79c4.shemminger@osdl.org>

Em Fri, Aug 15, 2003 at 02:07:40PM -0700, Stephen Hemminger escreveu:
> IPV6 won't build in current 2.6.0-test3 tree unless CONFIG_XFRM is defined
> because of reference to xfrm6_fini.
> 
> The linux way to fix this would be to make the functions
> stub's in the include file, but that isn't how IPV6 does it now
> for other xfrm functions.
> 
> diff -Nru a/net/ipv6/route.c b/net/ipv6/route.c
> --- a/net/ipv6/route.c	Fri Aug 15 14:04:05 2003
> +++ b/net/ipv6/route.c	Fri Aug 15 14:04:05 2003
> @@ -2000,7 +2000,9 @@
>  	proc_net_remove("ipv6_route");
>  	proc_net_remove("rt6_stats");
>  #endif
> +#ifdef CONFIG_XFRM
>  	xfrm6_fini();
> +#endif
>  	rt6_ifdown(NULL);
>  	fib6_gc_cleanup();
>  	kmem_cache_destroy(ip6_dst_ops.kmem_cachep);

Stephen,

	Couldn't this be ifdefed at the header that has the xfrm6_fini
prototype?

#ifndef CONFIG_XFRM
void xfrm6_fini(void) {}
#endif

	Or something like that.

- Arnaldo

  reply	other threads:[~2003-08-15 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-15 21:07 [PATCH] fix build problem with IPV6 Stephen Hemminger
2003-08-15 21:19 ` Arnaldo Carvalho de Melo [this message]
2003-08-16 14:50 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030815211938.GM1564@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).