* [PATCH] fix build problem with IPV6
@ 2003-08-15 21:07 Stephen Hemminger
2003-08-15 21:19 ` Arnaldo Carvalho de Melo
2003-08-16 14:50 ` David S. Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2003-08-15 21:07 UTC (permalink / raw)
To: YOSHIFUJI Hideaki, David S. Miller; +Cc: netdev
IPV6 won't build in current 2.6.0-test3 tree unless CONFIG_XFRM is defined
because of reference to xfrm6_fini.
The linux way to fix this would be to make the functions
stub's in the include file, but that isn't how IPV6 does it now
for other xfrm functions.
diff -Nru a/net/ipv6/route.c b/net/ipv6/route.c
--- a/net/ipv6/route.c Fri Aug 15 14:04:05 2003
+++ b/net/ipv6/route.c Fri Aug 15 14:04:05 2003
@@ -2000,7 +2000,9 @@
proc_net_remove("ipv6_route");
proc_net_remove("rt6_stats");
#endif
+#ifdef CONFIG_XFRM
xfrm6_fini();
+#endif
rt6_ifdown(NULL);
fib6_gc_cleanup();
kmem_cache_destroy(ip6_dst_ops.kmem_cachep);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix build problem with IPV6
2003-08-15 21:07 [PATCH] fix build problem with IPV6 Stephen Hemminger
@ 2003-08-15 21:19 ` Arnaldo Carvalho de Melo
2003-08-16 14:50 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2003-08-15 21:19 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: YOSHIFUJI Hideaki, David S. Miller, netdev
Em Fri, Aug 15, 2003 at 02:07:40PM -0700, Stephen Hemminger escreveu:
> IPV6 won't build in current 2.6.0-test3 tree unless CONFIG_XFRM is defined
> because of reference to xfrm6_fini.
>
> The linux way to fix this would be to make the functions
> stub's in the include file, but that isn't how IPV6 does it now
> for other xfrm functions.
>
> diff -Nru a/net/ipv6/route.c b/net/ipv6/route.c
> --- a/net/ipv6/route.c Fri Aug 15 14:04:05 2003
> +++ b/net/ipv6/route.c Fri Aug 15 14:04:05 2003
> @@ -2000,7 +2000,9 @@
> proc_net_remove("ipv6_route");
> proc_net_remove("rt6_stats");
> #endif
> +#ifdef CONFIG_XFRM
> xfrm6_fini();
> +#endif
> rt6_ifdown(NULL);
> fib6_gc_cleanup();
> kmem_cache_destroy(ip6_dst_ops.kmem_cachep);
Stephen,
Couldn't this be ifdefed at the header that has the xfrm6_fini
prototype?
#ifndef CONFIG_XFRM
void xfrm6_fini(void) {}
#endif
Or something like that.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix build problem with IPV6
2003-08-15 21:07 [PATCH] fix build problem with IPV6 Stephen Hemminger
2003-08-15 21:19 ` Arnaldo Carvalho de Melo
@ 2003-08-16 14:50 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-08-16 14:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: yoshfuji, netdev
On Fri, 15 Aug 2003 14:07:40 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> IPV6 won't build in current 2.6.0-test3 tree unless CONFIG_XFRM is defined
> because of reference to xfrm6_fini.
Applied, thanks Stephen.
> The linux way to fix this would be to make the functions
> stub's in the include file, but that isn't how IPV6 does it now
> for other xfrm functions.
If someone wants to clean house in this area, I'll happily
take patches doing that. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-16 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-15 21:07 [PATCH] fix build problem with IPV6 Stephen Hemminger
2003-08-15 21:19 ` Arnaldo Carvalho de Melo
2003-08-16 14:50 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).