* [PATCH] (5/5) irlap hashbin can be private
@ 2003-08-15 22:57 Stephen Hemminger
2003-08-16 15:09 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2003-08-15 22:57 UTC (permalink / raw)
To: Jean Tourrilhes; +Cc: irda-users, netdev
irlap hashbin is only used in one file, so make it private not global.
diff -Nru a/include/net/irda/irlap.h b/include/net/irda/irlap.h
--- a/include/net/irda/irlap.h Fri Aug 15 13:52:21 2003
+++ b/include/net/irda/irlap.h Fri Aug 15 13:52:21 2003
@@ -208,8 +208,6 @@
int next_bofs; /* Negotiated extra BOFs after next frame */
};
-extern hashbin_t *irlap;
-
/*
* Function prototypes
*/
diff -Nru a/net/irda/irlap.c b/net/irda/irlap.c
--- a/net/irda/irlap.c Fri Aug 15 13:52:21 2003
+++ b/net/irda/irlap.c Fri Aug 15 13:52:21 2003
@@ -48,7 +48,7 @@
#include <net/irda/timer.h>
#include <net/irda/qos.h>
-hashbin_t *irlap = NULL;
+static hashbin_t *irlap = NULL;
int sysctl_slot_timeout = SLOT_TIMEOUT * 1000 / HZ;
/* This is the delay of missed pf period before generating an event
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (5/5) irlap hashbin can be private
2003-08-15 22:57 [PATCH] (5/5) irlap hashbin can be private Stephen Hemminger
@ 2003-08-16 15:09 ` David S. Miller
2003-08-17 1:00 ` Jean Tourrilhes
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-08-16 15:09 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jt, irda-users, netdev
All 5 patches applied, thanks a lot Stephen.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (5/5) irlap hashbin can be private
2003-08-16 15:09 ` David S. Miller
@ 2003-08-17 1:00 ` Jean Tourrilhes
0 siblings, 0 replies; 3+ messages in thread
From: Jean Tourrilhes @ 2003-08-17 1:00 UTC (permalink / raw)
To: David S. Miller; +Cc: Stephen Hemminger, irda-users, netdev
On Sat, Aug 16, 2003 at 08:09:55AM -0700, David S. Miller wrote:
>
> All 5 patches applied, thanks a lot Stephen.
Thanks for the quick turn around !
By the way, if anybody care about that, I tested the patches
with real hardware (except irtty), and it was fine.
Have fun...
Jean
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-17 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-15 22:57 [PATCH] (5/5) irlap hashbin can be private Stephen Hemminger
2003-08-16 15:09 ` David S. Miller
2003-08-17 1:00 ` Jean Tourrilhes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).