From: Dan Aloni <da-x@gmx.net>
To: "David S. Miller" <davem@redhat.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
netdev@oss.sgi.com, mhuth@mvista.com
Subject: Re: [PATCH] network device renaming sysfs fix
Date: Sun, 17 Aug 2003 10:13:07 +0300 [thread overview]
Message-ID: <20030817071307.GA11408@callisto.yi.org> (raw)
In-Reply-To: <20030816074014.46b228f5.davem@redhat.com>
On Sat, Aug 16, 2003 at 07:40:14AM -0700, David S. Miller wrote:
> On Fri, 15 Aug 2003 09:37:24 -0700
> Stephen Hemminger <shemminger@osdl.org> wrote:
>
> > The class_dev kobject name is 20 chars and IFNAMSIZ is 16, so the solution
> > needs to truncate if new_name is not null terminated (all 16 chars long).
> >
> > This seems like the best approach:
>
> Patch applied, thanks everyone.
>
> Can't the device name also change via netlink messages?
> If so, do we handle that case properly?
No it can't, AFAIK. You might be confusing between netlink and
notifier calls (which allow ipv4 to update the names of aliases
when the device name changes).
BTW, it is possible to add notifier handling for fixing device
naming discrepancies regarding family-level sysctl registration.
I think this is how the sysctl issue should be fixed.
--
Dan Aloni
da-x@gmx.net
next prev parent reply other threads:[~2003-08-17 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-15 11:15 [PATCH] network device renaming sysfs fix Dan Aloni
2003-08-15 16:37 ` Stephen Hemminger
2003-08-15 16:50 ` Dan Aloni
2003-08-16 14:40 ` David S. Miller
2003-08-17 7:13 ` Dan Aloni [this message]
2003-08-15 18:09 ` Mark Huth
-- strict thread matches above, loose matches on Subject: below --
2003-08-15 11:36 Hen, Shmulik
2003-08-15 11:45 ` Dan Aloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030817071307.GA11408@callisto.yi.org \
--to=da-x@gmx.net \
--cc=davem@redhat.com \
--cc=mhuth@mvista.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).