From: Jeff Garzik <jgarzik@pobox.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: [bk patches] add ethtool_ops to net drivers
Date: Sun, 17 Aug 2003 14:38:48 -0400 [thread overview]
Message-ID: <20030817183848.GA18728@gtf.org> (raw)
Linus,
In order to maintain backwards compatibility and minimize impact,
netdev_ops mentioned at KS was scaled back to ethtool_ops. This allows
driver-at-a-time replacement often-duplicated ioctl handling code with a
Linux-style foo_ops set of function pointers.
Also, I've been waiting on this patch to begin attacking the stack
usage problems that often occur in ethtool ioctl handlers. Since gcc
sums instead of unions disjoint stack scopes (gcc bug #9997), huge
functions that handle a bunch of ioctls wind up eating way more stack
space than the programmer (rightfully) intended. ethtool_ops not
only makes a driver smaller, but it also neatly eliminates the stack
usage problem.
I much prefer this scaled back approach, which doesn't break anything,
and DaveM is ok with it as well. Please apply.
BitKeeper repo:
bk pull http://gkernel.bkbits.net/ethtool-2.6
Patch is also available from
ftp://ftp.kernel.org/pub/linux/kernel/people/jgarzik/patchkits/2.6/2.6.0-test3-bk5-ethtool1.patch.bz2
This will update the following files:
drivers/net/tg3.c | 664 +++++++++++++++++++--------------------------
include/linux/ethtool.h | 99 ++++++
include/linux/netdevice.h | 9
net/core/Makefile | 4
net/core/dev.c | 16 -
net/core/ethtool.c | 672 ++++++++++++++++++++++++++++++++++++++++++++++
6 files changed, 1076 insertions(+), 388 deletions(-)
through these ChangeSets:
<jgarzik@redhat.com> (03/08/07 1.1119.10.3)
[netdrvr] add SET_ETHTOOL_OPS back-compat hook
<jgarzik@redhat.com> (03/08/07 1.1119.10.2)
[netdrvr tg3] convert to using ethtool_ops
<jgarzik@redhat.com> (03/08/07 1.1119.10.1)
[netdrvr] add ethtool_ops to struct net_device, and associated infrastructure
Contributed by Matthew Wilcox.
next reply other threads:[~2003-08-17 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-17 18:38 Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-18 6:15 [bk patches] add ethtool_ops to net drivers Val Henson
2003-08-18 6:14 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030817183848.GA18728@gtf.org \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).