netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: netdev@oss.sgi.com
Subject: Re: dev_add_pack and hardware checksumming
Date: Sun, 17 Aug 2003 22:38:51 -0700	[thread overview]
Message-ID: <20030817223851.5185bdee.davem@redhat.com> (raw)
In-Reply-To: <20030818033711.GA21360@vana.vc.cvut.cz>

On Mon, 18 Aug 2003 05:37:11 +0200
Petr Vandrovec <vandrove@vc.cvut.cz> wrote:

>   For me it would be best if dev_queue_xmit_nit could just leave
> skb->h.raw alone,

The AF_PACKET layer depends upon skb->h.raw being set a certain
way.  Have a look at the dev_add_pack() registered hooks that
net/packet/af_packet.c uses.

> Other choice is doing checksumming in dev_queue_xmit_nit itself,
> before passing skb down to the registered packet handlers.

This is not an option either.  We're specifically not going to
undo checksum offloading just because tcpdump or some other
kind of tap is installed.

  reply	other threads:[~2003-08-18  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-18  3:37 dev_add_pack and hardware checksumming Petr Vandrovec
2003-08-18  5:38 ` David S. Miller [this message]
2003-08-18 18:27   ` Petr Vandrovec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030817223851.5185bdee.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).