From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Tommi Virtanen <tv@debian.org>
Cc: "David S. Miller" <davem@redhat.com>,
hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH] Change MAC without bringing interface down
Date: Mon, 18 Aug 2003 15:51:53 -0300 [thread overview]
Message-ID: <20030818185153.GA1559@conectiva.com.br> (raw)
In-Reply-To: <20030818171144.GC1793@lapdog>
Em Mon, Aug 18, 2003 at 08:11:44PM +0300, Tommi Virtanen escreveu:
> +void neigh_changeaddr(struct neigh_table *tbl, struct net_device *dev)
> +{
> + int i;
> +
> + write_lock_bh(&tbl->lock);
> +
> + for (i=0; i<=NEIGH_HASHMASK; i++) {
spaces before and after operators, please
> +struct notifier_block arp_netdev_notifier = {
> + arp_netdev_event,
> + NULL,
> + 0
> +};
c99 style please, that is:
struct notifier_block arp_netdev_notifier = {
.notifier_call = arp_netdev_event,
}
> +struct notifier_block ndisc_netdev_notifier = {
> + ndisc_netdev_event,
> + NULL,
> + 0
> +};
ditto
Thanks,
- Arnaldo
next prev parent reply other threads:[~2003-08-18 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-18 9:13 [PATCH] Change MAC without bringing interface down Tommi Virtanen
2003-08-18 11:19 ` David S. Miller
2003-08-18 12:13 ` jamal
2003-08-18 12:12 ` David S. Miller
2003-08-18 13:03 ` jamal
2003-08-18 16:04 ` Tommi Virtanen
2003-08-18 16:06 ` David S. Miller
2003-08-18 17:11 ` Tommi Virtanen
2003-08-18 18:51 ` Arnaldo Carvalho de Melo [this message]
2003-08-19 5:50 ` Tommi Virtanen
2003-08-19 15:42 ` Arnaldo Carvalho de Melo
2003-08-19 19:31 ` David S. Miller
2003-08-18 14:24 ` Tommi Virtanen
2003-08-18 14:20 ` David S. Miller
2003-08-18 15:10 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030818185153.GA1559@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=tv@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).