* [PATCH] make pktgen depends on procfs [2.6.0-test3]
@ 2003-08-18 21:26 Daniele Bellucci
2003-08-19 13:54 ` Robert Olsson
0 siblings, 1 reply; 4+ messages in thread
From: Daniele Bellucci @ 2003-08-18 21:26 UTC (permalink / raw)
To: netdev; +Cc: davem
IMHO pktgen should depends on proc fs to avoid the following compilation error:
net/core/pktgen.c: In function `create_proc_dir':
net/core/pktgen.c:1296: `proc_net' undeclared (first use in this function)
net/core/pktgen.c:1296: (Each undeclared identifier is reported only once
net/core/pktgen.c:1296: for each function it appears in.)
make[2]: *** [net/core/pktgen.o] Error 1
make[1]: *** [net/core] Error 2
make: *** [net] Error 2
diff -urN 1.0/net/Kconfig 1.1/net/Kconfig
--- 1.0/net/Kconfig 2003-08-18 23:25:02.000000000 +0200
+++ 1.1/net/Kconfig 2003-08-18 23:25:13.000000000 +0200
@@ -661,6 +661,7 @@
config NET_PKTGEN
tristate "Packet Generator (USE WITH CAUTION)"
+ depends on CONFIG_PROC_FS
---help---
This module will inject preconfigured packets, at a configurable
rate, out of a given interface. It is used for network interface
--
Daniele.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] make pktgen depends on procfs [2.6.0-test3]
2003-08-18 21:26 [PATCH] make pktgen depends on procfs [2.6.0-test3] Daniele Bellucci
@ 2003-08-19 13:54 ` Robert Olsson
2003-08-19 13:58 ` Daniele Bellucci
2003-08-20 4:08 ` David S. Miller
0 siblings, 2 replies; 4+ messages in thread
From: Robert Olsson @ 2003-08-19 13:54 UTC (permalink / raw)
To: bellucda; +Cc: netdev, davem
Daniele Bellucci writes:
> IMHO pktgen should depends on proc fs to avoid the following compilation error:
>
Hello!
It should be changed to:
diff -urN 1.0/net/Kconfig 1.1/net/Kconfig
--- 1.0/net/Kconfig 2003-08-18 23:25:02.000000000 +0200
+++ 1.1/net/Kconfig 2003-08-18 23:25:13.000000000 +0200
@@ -661,6 +661,7 @@
config NET_PKTGEN
tristate "Packet Generator (USE WITH CAUTION)"
+ depends on PROC_FS
---help---
This module will inject preconfigured packets, at a configurable
rate, out of a given interface. It is used for network interface
> + depends on CONFIG_PROC_FS
Cheers.
--ro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make pktgen depends on procfs [2.6.0-test3]
2003-08-19 13:54 ` Robert Olsson
@ 2003-08-19 13:58 ` Daniele Bellucci
2003-08-20 4:08 ` David S. Miller
1 sibling, 0 replies; 4+ messages in thread
From: Daniele Bellucci @ 2003-08-19 13:58 UTC (permalink / raw)
To: Robert Olsson; +Cc: netdev, davem
> Hello!
> It should be changed to:
>
> diff -urN 1.0/net/Kconfig 1.1/net/Kconfig
> --- 1.0/net/Kconfig 2003-08-18 23:25:02.000000000 +0200
> +++ 1.1/net/Kconfig 2003-08-18 23:25:13.000000000 +0200
> @@ -661,6 +661,7 @@
>
> config NET_PKTGEN
> tristate "Packet Generator (USE WITH CAUTION)"
> + depends on PROC_FS
> ---help---
> This module will inject preconfigured packets, at a configurable
> rate, out of a given interface. It is used for network interface
>
> > + depends on CONFIG_PROC_FS
>
> Cheers.
> --ro
Argh !%$@#! i've post the wrong version ;(
--
Daniele.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make pktgen depends on procfs [2.6.0-test3]
2003-08-19 13:54 ` Robert Olsson
2003-08-19 13:58 ` Daniele Bellucci
@ 2003-08-20 4:08 ` David S. Miller
1 sibling, 0 replies; 4+ messages in thread
From: David S. Miller @ 2003-08-20 4:08 UTC (permalink / raw)
To: Robert Olsson; +Cc: bellucda, netdev
On Tue, 19 Aug 2003 15:54:33 +0200
Robert Olsson <Robert.Olsson@data.slu.se> wrote:
> diff -urN 1.0/net/Kconfig 1.1/net/Kconfig
> --- 1.0/net/Kconfig 2003-08-18 23:25:02.000000000 +0200
> +++ 1.1/net/Kconfig 2003-08-18 23:25:13.000000000 +0200
> @@ -661,6 +661,7 @@
>
> config NET_PKTGEN
> tristate "Packet Generator (USE WITH CAUTION)"
> + depends on PROC_FS
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-08-20 4:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-18 21:26 [PATCH] make pktgen depends on procfs [2.6.0-test3] Daniele Bellucci
2003-08-19 13:54 ` Robert Olsson
2003-08-19 13:58 ` Daniele Bellucci
2003-08-20 4:08 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).