* dev/core/net_sysfs.c: missing release() function in net_class
@ 2003-08-19 12:47 Ville Nuorvala
2003-08-19 15:36 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Ville Nuorvala @ 2003-08-19 12:47 UTC (permalink / raw)
To: shemminger; +Cc: greg, netdev
Hi,
lately I've been getting a nasty looking warning from class_dev_release()
in drivers/base/class.c when I unregister my ip6_tunnel devices.
The warning (added by Greg Kroah-Hartman in cset 1.1152.2.7) is apparently
triggered because net_class doesn't have .release set.
Would an empty dummy function be enough for net_class or should the
release function actually do something?
Thanks,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dev/core/net_sysfs.c: missing release() function in net_class
2003-08-19 12:47 dev/core/net_sysfs.c: missing release() function in net_class Ville Nuorvala
@ 2003-08-19 15:36 ` David S. Miller
2003-08-20 11:23 ` [PATCH] IPv6: Fix target address for (proxy/anycast) NA Ville Nuorvala
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2003-08-19 15:36 UTC (permalink / raw)
To: Ville Nuorvala; +Cc: shemminger, greg, netdev
On Tue, 19 Aug 2003 15:47:03 +0300 (EEST)
Ville Nuorvala <vnuorval@tcs.hut.fi> wrote:
> lately I've been getting a nasty looking warning from class_dev_release()
> in drivers/base/class.c when I unregister my ip6_tunnel devices.
This is fixed in current sources after recent changes
done by Stephen Hemminger.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] IPv6: Fix target address for (proxy/anycast) NA
2003-08-19 15:36 ` David S. Miller
@ 2003-08-20 11:23 ` Ville Nuorvala
2003-08-20 18:20 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Ville Nuorvala @ 2003-08-20 11:23 UTC (permalink / raw)
To: davem, usagi-core; +Cc: netdev
[-- Attachment #1: Type: TEXT/PLAIN, Size: 339 bytes --]
Hi,
the target address in neighbor advertisements must be the solicited
address. Otherwise proxy NAs (and NAs for anycast addresses) don't work.
Please apply!
Thanks,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257
[-- Attachment #2: Type: TEXT/PLAIN, Size: 452 bytes --]
--- linux-2.5.OLD/net/ipv6/ndisc.c 2003-08-20 14:09:13.000000000 +0300
+++ linux-2.5/net/ipv6/ndisc.c 2003-08-20 14:09:28.000000000 +0300
@@ -485,7 +485,7 @@
msg->icmph.icmp6_override = !!override;
/* Set the target address. */
- ipv6_addr_copy(&msg->target, src_addr);
+ ipv6_addr_copy(&msg->target, solicited_addr);
if (inc_opt)
ndisc_fill_option(msg->opt, ND_OPT_TARGET_LL_ADDR, dev->dev_addr, dev->addr_len);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-08-20 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-19 12:47 dev/core/net_sysfs.c: missing release() function in net_class Ville Nuorvala
2003-08-19 15:36 ` David S. Miller
2003-08-20 11:23 ` [PATCH] IPv6: Fix target address for (proxy/anycast) NA Ville Nuorvala
2003-08-20 18:20 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).