* [PATCH] set owner field on /proc/net/irda sub entries
@ 2003-08-18 18:19 Stephen Hemminger
2003-08-20 4:11 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-08-18 18:19 UTC (permalink / raw)
To: Jean Tourrilhes; +Cc: netdev, irda-users
common net/irda code in 2.6.0-test3 creates directory and sub entries,
but forgets to set owner field on sub entries.
diff -Nru a/net/irda/irproc.c b/net/irda/irproc.c
--- a/net/irda/irproc.c Mon Aug 18 11:08:23 2003
+++ b/net/irda/irproc.c Mon Aug 18 11:08:23 2003
@@ -62,14 +62,18 @@
void __init irda_proc_register(void)
{
int i;
+ struct proc_dir_entry *d;
proc_irda = proc_mkdir("net/irda", NULL);
if (proc_irda == NULL)
return;
proc_irda->owner = THIS_MODULE;
- for (i=0; i<ARRAY_SIZE(dir); i++)
- create_proc_info_entry(dir[i].name,0,proc_irda,dir[i].fn);
+ for (i=0; i<ARRAY_SIZE(dir); i++) {
+ d = create_proc_info_entry(dir[i].name,0,proc_irda,dir[i].fn);
+ if (d)
+ d->owner = THIS_MODULE;
+ }
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] set owner field on /proc/net/irda sub entries
2003-08-18 18:19 [PATCH] set owner field on /proc/net/irda sub entries Stephen Hemminger
@ 2003-08-20 4:11 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-08-20 4:11 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jt, netdev, irda-users
On Mon, 18 Aug 2003 11:19:42 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> common net/irda code in 2.6.0-test3 creates directory and sub entries,
> but forgets to set owner field on sub entries.
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-20 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-18 18:19 [PATCH] set owner field on /proc/net/irda sub entries Stephen Hemminger
2003-08-20 4:11 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).