netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] Tigon3 driver update
Date: Sun, 24 Aug 2003 02:05:00 -0400	[thread overview]
Message-ID: <20030824060500.GA28682@gtf.org> (raw)
In-Reply-To: <20030823214939.0c012f3d.davem@redhat.com>

On Sat, Aug 23, 2003 at 09:49:39PM -0700, David S. Miller wrote:
> 
> Included is a Tigon3 driver test patch against current
> 2.6.0-testX kernels.
> 
> Features:
> 
> 1) Full 5705/5782/5788/5901 support.
> 2) More reliable PHY resetting on 5703/5704/5705.
> 3) Updated TSO support, it is not enabled by default
>    but one can turn it on using a current version of ethtool.
> 
> Feedback welcome.

Looks good, thanks.  One minor:

The tg3_[gs]et_tso code should be generic, like the tiny helpers at the
top of net/core/ethtool.c.  (well, tg3_get_tso is generic, and
tg3_set_tso could call the generic helper)

	Jeff

  reply	other threads:[~2003-08-24  6:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-24  4:49 [PATCH] Tigon3 driver update David S. Miller
2003-08-24  6:05 ` Jeff Garzik [this message]
2003-08-24 10:15   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030824060500.GA28682@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=davem@redhat.com \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).