From: Pete Zaitcev <zaitcev@redhat.com>
To: linux390@de.ibm.com
Cc: netdev@oss.sgi.com, Pete Zaitcev <zaitcev@redhat.com>
Subject: Patch for oops in ctc
Date: Sun, 24 Aug 2003 17:58:16 -0400 [thread overview]
Message-ID: <20030824175816.A872@devserv.devel.redhat.com> (raw)
Martin & others:
the following bug is still with us. What's the deal?
The matter is clear, calling dst_link_failure from an
interrupt is illegal (and pointless).
I have a separate patch which adds carrier control to ctc
according to DaveM's suggestions, but let's at least fix
the bug first.
-- Pete
diff -ur -X dontdiff linux-2.6.0-test4/drivers/s390/net/ctcmain.c linux-2.6.0-test4-s390/drivers/s390/net/ctcmain.c
--- linux-2.6.0-test4/drivers/s390/net/ctcmain.c 2003-08-24 14:24:50.000000000 -0700
+++ linux-2.6.0-test4-s390/drivers/s390/net/ctcmain.c 2003-08-24 14:53:25.000000000 -0700
@@ -2441,14 +2441,12 @@
/**
* If channels are not running, try to restart them
- * notify anybody about a link failure and throw
- * away packet.
+ * and throw away packet.
*/
if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
fsm_event(privptr->fsm, DEV_EVENT_START, dev);
if (privptr->protocol == CTC_PROTO_LINUX_TTY)
return -EBUSY;
- dst_link_failure(skb);
dev_kfree_skb(skb);
privptr->stats.tx_dropped++;
privptr->stats.tx_errors++;
diff -ur -X dontdiff linux-2.6.0-test4/drivers/s390/net/netiucv.c linux-2.6.0-test4-s390/drivers/s390/net/netiucv.c
--- linux-2.6.0-test4/drivers/s390/net/netiucv.c 2003-08-24 14:24:50.000000000 -0700
+++ linux-2.6.0-test4-s390/drivers/s390/net/netiucv.c 2003-08-24 14:51:10.000000000 -0700
@@ -1195,12 +1195,10 @@
/**
* If connection is not running, try to restart it
- * notify anybody about a link failure and throw
- * away packet.
+ * and throw away packet.
*/
if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
fsm_event(privptr->fsm, DEV_EVENT_START, dev);
- dst_link_failure(skb);
dev_kfree_skb(skb);
privptr->stats.tx_dropped++;
privptr->stats.tx_errors++;
reply other threads:[~2003-08-24 21:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030824175816.A872@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux390@de.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).