From: Greg KH <greg@kroah.com>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev <netdev@oss.sgi.com>,
Jeff Garzik <jgarzik@pobox.com>,
"Feldman, Scott" <scott.feldman@intel.com>,
Larry Kessler <kessler@us.ibm.com>,
Randy Dunlap <rddunlap@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/4] Net device error logging, revised
Date: Tue, 26 Aug 2003 11:32:21 -0700 [thread overview]
Message-ID: <20030826183221.GB3167@kroah.com> (raw)
In-Reply-To: <3F4A8027.6FE3F594@us.ibm.com>
On Mon, Aug 25, 2003 at 02:31:19PM -0700, Jim Keniston wrote:
> +int __netdev_printk(const char *sevlevel, const struct net_device *netdev,
> + int msglevel, const char *format, ...)
> +{
> + if (!netdev || !format) {
> + return -EINVAL;
> + }
> + if (msglevel == NETIF_MSG_ALL || (netdev->msg_enable & msglevel)) {
> + char msg[512];
512 bytes on the stack? Any way to prevent this from happening? With
the push to make the stack even smaller in 2.7, people will not like
this.
thanks,
greg k-h
next prev parent reply other threads:[~2003-08-26 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-25 21:31 [PATCH 1/4] Net device error logging, revised Jim Keniston
2003-08-25 21:39 ` Subject: [PATCH 2/4] Net device error logging, revised (e100) Jim Keniston
2003-08-25 21:41 ` Subject: [PATCH 3/4] Net device error logging, revised (e1000) Jim Keniston
2003-08-25 21:43 ` [PATCH 4/4] Net device error logging, revised (tg3) Jim Keniston
2003-08-26 18:32 ` Greg KH [this message]
2003-08-26 23:34 ` [PATCH 1/4] Net device error logging, revised Jim Keniston
2003-08-26 23:51 ` Jeff Garzik
2003-08-27 1:07 ` Jim Keniston
2003-09-03 17:32 ` Jeff Garzik
2003-09-03 20:56 ` Jim Keniston
2003-08-27 1:06 ` Stephen Hemminger
2003-08-29 21:22 ` Jim Keniston
2003-09-15 23:08 ` [PATCH] " Jim Keniston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826183221.GB3167@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=jkenisto@us.ibm.com \
--cc=kessler@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).