From: "David S. Miller" <davem@redhat.com>
To: Vinay K Nallamothu <vinay-rc@naturesoft.net>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.0-test4][IPv6] ip6_flowlabel.c: timer cleanups
Date: Wed, 27 Aug 2003 23:25:14 -0700 [thread overview]
Message-ID: <20030827232514.0854fc06.davem@redhat.com> (raw)
In-Reply-To: <1061907882.1108.28.camel@lima.royalchallenge.com>
On 26 Aug 2003 19:54:41 +0530
Vinay K Nallamothu <vinay-rc@naturesoft.net> wrote:
> @@ -104,10 +105,9 @@
> fl->opt = NULL;
> kfree(opt);
> }
> - if (!del_timer(&ip6_fl_gc_timer) ||
> - (long)(ip6_fl_gc_timer.expires - ttd) > 0)
> - ip6_fl_gc_timer.expires = ttd;
> - add_timer(&ip6_fl_gc_timer);
> + if (!timer_pending(&ip6_fl_gc_timer) ||
> + time_after(ip6_fl_gc_timer.expires, ttd))
> + mod_timer(&ip6_fl_gc_timer, ttd);
> }
> }
>
This code is still racey. This code needs to hold the
toplevel ip6_fl_lock during the GC timer manipulations
and tests.
prev parent reply other threads:[~2003-08-28 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 14:24 [PATCH 2.6.0-test4][IPv6] ip6_flowlabel.c: timer cleanups Vinay K Nallamothu
2003-08-28 6:25 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030827232514.0854fc06.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=vinay-rc@naturesoft.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).