netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: netdev@oss.sgi.com
Subject: 100 network limit
Date: Fri, 29 Aug 2003 04:00:19 +1000	[thread overview]
Message-ID: <20030828180019.GH12541@krispykreme> (raw)


Hi,

We hit the 100 network naming limit :) Yes the comment is correct, we
need to fix the algorithm. dev_base_lock really starts to show up
(eg in dev_get_by_index), especially when doing IO to raw sockets
(does every packet to a raw socket result in a dev_get_by_index? Couldnt
we embed a pointer to the device in the socket?)

Anyway as a short term fix Jamal suggested making a sysctl for this
maximum. If fixing this all properly is out of the question for 2.6,
would the sysctl approach be satisfactory? The other option is to just
bump the limit and recognise that the user is on his own if performance
sucks.

Anton

diff -ru gr14/net/core/dev.c gr14_work/net/core/dev.c
--- gr14/net/core/dev.c	2003-08-18 13:40:43.000000000 -0500
+++ gr14_work/net/core/dev.c	2003-08-28 12:56:45.000000000 -0500
@@ -630,9 +630,9 @@
 		return -EINVAL;
 
 	/*
-	 * If you need over 100 please also fix the algorithm...
+	 * If you need over 200 please also fix the algorithm...
 	 */
-	for (i = 0; i < 100; i++) {
+	for (i = 0; i < 200; i++) {
 		snprintf(buf, sizeof(buf), name, i);
 		if (!__dev_get_by_name(buf)) {
 			strcpy(dev->name, buf);

             reply	other threads:[~2003-08-28 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-28 18:00 Anton Blanchard [this message]
2003-08-28 19:08 ` 100 network limit Andi Kleen
2003-08-28 21:46   ` Ben Greear
2003-08-28 23:41     ` David S. Miller
2003-08-29  3:45       ` Ben Greear
2003-08-29  0:03     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030828180019.GH12541@krispykreme \
    --to=anton@samba.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).